Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Preroll ads shown as black screen when disabling 'Ads Blocking' in shields #7501

Closed
Uni-verse opened this issue May 23, 2023 · 1 comment · Fixed by #7507
Closed

Preroll ads shown as black screen when disabling 'Ads Blocking' in shields #7501

Uni-verse opened this issue May 23, 2023 · 1 comment · Fixed by #7507

Comments

@Uni-verse
Copy link
Contributor

Description:

When Ads Blocking is disabled in shields panels, pre-roll ads will show black screen when playing. This does not happen when shields are disabled, the ads play/show normally.

Not a regression. Impacts 1.51, 1.51.1

Steps to Reproduce

  1. Install 1.51
  2. Wait a few mins after installing
  3. Open youtube.com
  4. Disable Tracking & Ads Blocking toggle in shields
  5. Play a popular video with ads
  6. Observe ad

Actual result:

IMG_3220 2

Expected result:

IMG_3240

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version: 1.51.x

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone X, iOS 16.3.1

@hffvld
Copy link
Collaborator

hffvld commented Jun 1, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5]
Version: 1.52 (23.6.1.16)
BraveCore: 1.52.117 (114.0.5735.90)

STEPS:

  1. Launch Brave
  2. Wait a few mins after installing
  3. Open youtube.com
  4. Brave Shields > Disable Trackers & Ads Blocking toggle
  5. Play a popular video with ads > Verify

ACTUAL RESULTS:

  • Verified that ads are shown when Trackers & Ads Blocking toggle is OFF
Ads.2.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.