Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Crash - Sometimes when closing a tab, the browser crashes #7548

Closed
Brandon-T opened this issue May 31, 2023 · 0 comments · Fixed by #7547
Closed

Crash - Sometimes when closing a tab, the browser crashes #7548

Brandon-T opened this issue May 31, 2023 · 0 comments · Fixed by #7547

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • Sometimes, when a user closes a tab, the browser crashes.
  • Crash log shows it's Tab.deinit in the Xcode organizer.

Steps to Reproduce

  1. Close some Tabs

Actual result:

  • Crash

Expected result:

  • Shouldn't crash

Reproduces how often: [Easily reproduced, Intermittent Issue]

  • Very very hard to reproduce

Brave Version:

  • 1.49.x

Device details:

  • iPhone
@Brandon-T Brandon-T added this to the 1.52 milestone May 31, 2023
@Brandon-T Brandon-T self-assigned this May 31, 2023
iccub pushed a commit that referenced this issue Jun 1, 2023
Access everything from brave-core weakly. If tab deallocates, all of the objects deallocate under the hood.
The weak references become nil. If they are still for some reason doing an operation, well it should be cancelled.

Fix possible favicon crash
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…e-ios#7547)

Access everything from brave-core weakly. If tab deallocates, all of the objects deallocate under the hood.
The weak references become nil. If they are still for some reason doing an operation, well it should be cancelled.

Fix possible favicon crash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants