Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1871: Change grant claimed copy for ads grants #1933

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

kylehickinson
Copy link
Collaborator

Needs translations pushed to transifex after

Summary of Changes

This pull request fixes issue #1871

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • At the moment, easiest way is to fake the grant type at GrantClaimedViewController creation.

Screenshots:

Regular Grant Ads Grant
IMG_4401 IMG_4402

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when we should push to transifex, perhaps there's more string changes incoming

@kylehickinson kylehickinson merged commit f1858b6 into development Nov 12, 2019
@kylehickinson kylehickinson deleted the ads-grant-copy branch November 12, 2019 14:22
@kylehickinson
Copy link
Collaborator Author

There'll be more strings coming here: #443

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants