This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1467: Display a QuickLook preview when tapping a downloaded file #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
commented
Nov 18, 2019
Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/DownloadsViewController.swift
Show resolved
Hide resolved
iccub
suggested changes
Nov 18, 2019
| } | ||
| } | ||
|
|
||
| class PreviewingDataSource: NSObject, QLPreviewControllerDataSource { |
Falls back to previous logic if the QuickLook service isn't able to preview the document type
kylehickinson
force-pushed
the
preview-downloads
branch
from
619d944
to
e907b69
Compare
iccub
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falls back to previous logic if the QuickLook service isn't able to preview the document type
Summary of Changes
This pull request fixes issue #1467
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Examples:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement