This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3358 - Update httpse data files #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
approved these changes
Mar 11, 2021
iccub
reviewed
Mar 11, 2021
| @@ -336,6 +336,7 @@ class BrowserViewController: UIViewController { | |||
| } | |||
| Preferences.NewTabPage.selectedCustomTheme.observe(from: self) | |||
| // Lists need to be compiled before attempting tab restoration | |||
| ContentBlockerHelper.clearBlockingRules() | |||
There was a problem hiding this comment.
@kylehickinson worked on this more, I will leave this part to him,
if you want me to take over and look closer at it, let me know Kyle
Brandon-T
approved these changes
Mar 11, 2021
kylehickinson
suggested changes
Mar 11, 2021
| @@ -336,6 +336,7 @@ class BrowserViewController: UIViewController { | |||
| } | |||
| Preferences.NewTabPage.selectedCustomTheme.observe(from: self) | |||
| // Lists need to be compiled before attempting tab restoration | |||
| ContentBlockerHelper.clearBlockingRules() | |||
There was a problem hiding this comment.
@jumde to fix potential race condition around not waiting for removeContentRuleList completion handler
jumde
force-pushed
the
update-httpse
branch
4 times, most recently
from
3708e4a
to
c446d99
Compare
kylehickinson
approved these changes
Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #3358
Submitter Checklist:
NSLocalizableString()Test Plan:
HTTPS Everywhereis workingScreenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement