Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7337: Update reset wallet button copy #7338

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

This pull request fixes #7337

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Open Web3 settings with a wallet setup and verify copy is Reset and Clear Wallet Data

Screenshots:

reset wallet

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps requested a review from a team as a code owner April 26, 2023 13:44
@StephenHeaps StephenHeaps self-assigned this Apr 26, 2023
@StephenHeaps StephenHeaps added this to the 1.51 milestone Apr 26, 2023
@StephenHeaps StephenHeaps merged commit 145759c into development Apr 27, 2023
@StephenHeaps StephenHeaps deleted the wallet/reset-wallet-copy branch April 27, 2023 13:15
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update wallet reset title
2 participants