Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7467: Add support for using component updater to fetch background & sponsored images #7634

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix #7467: Add support for using component updater to fetch background & sponsored images #7634

merged 2 commits into from
Jun 23, 2023

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #7467

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Test usual NTP image/SI logic

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner June 22, 2023 19:55
iccub
iccub approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. tested on iPhone and iPad sims
nice job. makes our code a bit cleaner too

@kylehickinson kylehickinson added this to the 1.53 milestone Jun 23, 2023
@kylehickinson kylehickinson merged commit 34a90d9 into development Jun 23, 2023
@kylehickinson kylehickinson deleted the ntp-backgrounds-component-updater branch June 23, 2023 16:55
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7467: Add support for using component updater to …
635f054 
…fetch background & sponsored images (brave/brave-ios#7634)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.56
Development

Successfully merging this pull request may close these issues.

Update NTP images
2 participants
@kylehickinson @iccub