Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7601: Force locale & calendar for news date decoding formatter #7711

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

kylehickinson
Copy link
Collaborator

It seems somehow on certain devices in the UK, date decoding is failing. I couldn't reproduce locally unfortunately so this solution is untested though hopefully the correct one

Summary of Changes

This pull request fixes #7601

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner July 10, 2023 20:06
@kylehickinson kylehickinson added this to the 1.56 milestone Jul 11, 2023
@kylehickinson kylehickinson merged commit fecd586 into development Jul 11, 2023
7 checks passed
@kylehickinson kylehickinson deleted the news-uk-load branch July 11, 2023 14:27
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: News doesn't load on iOS in UK
2 participants