Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5357: Add back scale aspect fit to Favicons #7906

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Aug 21, 2023

Summary of Changes

  • Not sure if this was reverted or broke during a rebase somewhere, but adding contentMode = .scaleAspectFit so favicons don't stretch weirdly

This pull request fixes #5357

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Screenshots:

image

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.57 milestone Aug 21, 2023
@Brandon-T Brandon-T self-assigned this Aug 21, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner August 21, 2023 12:28
@iccub iccub merged commit fabd44d into development Aug 21, 2023
7 checks passed
@iccub iccub deleted the bugfix/FaviconStretched branch August 21, 2023 17:04
iccub pushed a commit that referenced this pull request Aug 21, 2023
Add back scale aspect fit. Seems to have been reverted or broke during a rebase?
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…e/brave-ios#7906)

Add back scale aspect fit. Seems to have been reverted or broke during a rebase?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tab page favicons show a planet instead of the Brave icon
3 participants