Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8095: Favorites are shown in Private Tab mode when switching the apps #8119

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Sep 21, 2023

Summary of Changes

This pull request fixes #8095

Hide Active background favorites when backgrounding the app in private mode

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Begin Brave
  • Open NTP in Private Tab mode
  • Tap Search button > Use the app switch gesture to see all opened apps > Observe

Screenshots:

1testss

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.59 milestone Sep 21, 2023
@soner-yuksel soner-yuksel enabled auto-merge (squash) September 21, 2023 19:01
@soner-yuksel soner-yuksel merged commit 9799d6a into development Sep 21, 2023
8 checks passed
@soner-yuksel soner-yuksel deleted the fix/private-favourites-bg branch September 21, 2023 19:19
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #6577] Favorites are shown in Private Tab mode when switching the apps
2 participants