Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8013: Fix Playlist Crash on iPad due to invalid Scene #8162

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix #8013: Fix Playlist Crash on iPad due to invalid Scene #8162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Brave/Frontend/Browser/Playlist/Controllers/PlaylistListViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ extension PlaylistListViewController {
}
}

let items = try await PlaylistSharedFolderNetwork.fetchMediaItemInfo(item: model, viewForInvisibleWebView: self.view)
let items = try await PlaylistSharedFolderNetwork.fetchMediaItemInfo(item: model, viewForInvisibleWebView: self.playerView.window ?? self.playerView.superview ?? self.playerView)
try Task.checkCancellation()

try folder.playlistItems?.forEach({ playlistItem in
Expand Down
2 changes: 1 addition & 1 deletion Sources/Brave/Frontend/Browser/Playlist/Managers & Cache/PlaylistCacheLoader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ class PlaylistWebLoader: UIView {

guard let webView = tab.webView,
let browserViewController = self.currentScene?.browserViewController else {
continuation.resume(returning: nil)
self.handler?(nil)
return
}

Expand Down