Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix compiling only necessary files during launch #8749

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Feb 8, 2024

Summary of Changes

This PR prepares for the list_catalog.json and fixes a number of issues during launch

  1. Don't compile custom filter lists upon launch (this could have been causing load hangs for people with custom filter lists)
  2. Explicitly don't compile shown filter lists upon launch. (it will compile hidden filter lists but those do not appear until we switch to list_catalog.json). There is no change in behaviour because there was a bug in the code which causes no filter lists to compile
  3. Add signposts for some better launch profiling

Note except for part 2, none of this should affect launch performance. Later work will be done to improve launch performance (we will attempt to save and load dat files in the future which should give a performance boost)

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Test adblocking and launch performance.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner February 8, 2024 00:02
@cuba cuba force-pushed the js/fix-compiling-unecesssary-contentent-blockers-on-launch branch 2 times, most recently from 25f25ce to 62c8802 Compare February 8, 2024 00:12
@cuba cuba force-pushed the js/fix-compiling-unecesssary-contentent-blockers-on-launch branch from 62c8802 to 8246084 Compare February 8, 2024 22:43
@cuba
Copy link
Contributor Author

cuba commented Feb 13, 2024

merged with brave-core's list catalog PR

@cuba cuba closed this Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant