Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Tipping Broken #100

Closed
jonathansampson opened this issue Aug 30, 2023 · 3 comments
Closed

Inline Tipping Broken #100

jonathansampson opened this issue Aug 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@jonathansampson
Copy link

The .js-actions selector no longer works, and as a result the inline tipping button is no longer added.

brave-site-specific-scripts/scripts/brave_rewards/publisher/twitter/tipping.ts

Line 280 in f0079ae

actions = tweets[i].querySelector('.js-actions')

@jonathansampson jonathansampson added the bug Something isn't working label Aug 30, 2023
@zenparsing
Copy link
Contributor

It may be possible to get all of the information that we need from a property on one of the DOM objects. See here for an implementation of this idea.

@emerick
Copy link
Contributor

emerick commented Aug 30, 2023

@jonathansampson One thing to be aware of is that we did explicitly disable inline tipping on Twitter recently when we first encountered issues with their API: brave/brave-browser#32107

jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
6fbaf15 
Addresses #100
@jonathansampson jonathansampson mentioned this issue Sep 27, 2023
Closed
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
2b7f4c4 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
cfee1e1 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
6e574e0 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
dba3c77 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
f9e5f82 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
f75fb2b 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
a66921a 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
9f73f12 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 27, 2023
@jonathansampson
Proposes alternative tipping logic
550976d 
Addresses #100
jonathansampson added a commit that referenced this issue Sep 28, 2023
@jonathansampson
Proposes alternative tipping logic
ec65d60 
Addresses #100
@Miyayes
Copy link
Collaborator

Miyayes commented Nov 20, 2023

Inline Tip buttons feature removed completely.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathansampson @emerick @zenparsing @Miyayes