This repository has been archived by the owner on May 13, 2024. It is now read-only.
Rewards ads android #477
Closed
Rewards ads android #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more sense when considering there are different messages for different reasons of ads not being available to the user. There are corresponding PRs on consuming products to use the renamed IDs
petemill
force-pushed
the
rewards-ads-android
branch
from
16f766e
to
eb5718f
Compare
28 tasks
rossmoody
reviewed
May 29, 2019
| @@ -40,6 +12,7 @@ import { | |||
| import { List } from '../../' | |||
| import { getLocale } from '../../../../helpers' | |||
| import Toggle from '../../../../components/formControls/toggle/index' | |||
| import * as Styled from './style' | |||
|
Updated (deployment link included) to add GrantComplete customization |
Remains backwards-compatible
29 tasks
tmancey
force-pushed
the
rewards-ads-android
branch
3 times, most recently
from
3b60c91
to
b0e39a4
Compare
Fixing detail view and settings page logic error (boxMobile) [Android]
BAP/Points updates for android rewards settings
|
@petemill Just FYI, I pulled these changes into brave/brave-core#3886. |
Fixes untranslated string on Android
|
closing as this was resolved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewards feature supported for ads on android (settings page).
Required by android branch at brave/brave-core#2508
Test plan
Link / storybook path to visual changes
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?