Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Check for empty frame when window state isn't updated yet
Browse files Browse the repository at this point in the history
Fix #10749

I don't think I can add a test for this since it's so unfrequent but it will go away once we get rid of frame state
  • Loading branch information
bbondy committed Aug 31, 2017
1 parent 8b6d64c commit 1e2c5eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/stores/windowStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ const newFrame = (state, frameOpts) => {
const tabId = frameOpts.tabId
const frame = frameStateUtil.getFrameByTabId(state, tabId)
state = frameStateUtil.updateTabPageIndex(state, tabId)
if (active) {
if (active && frame) {
// only set the activeFrameKey if the tab is already active
state = state.set('activeFrameKey', frame.get('key'))
} else {
Expand Down

0 comments on commit 1e2c5eb

Please sign in to comment.