Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Convert background page to event page
Browse files Browse the repository at this point in the history 
Auditors: @bridiver

Fix #6498
  • Loading branch information
@bbondy
bbondy committed Jan 2, 2017
1 parent 432d060 commit 23203e1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/extensions.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ let generateBraveManifest = () => {
manifest_version: 2,
version: '1.0',
background: {
scripts: [ 'content/scripts/idleHandler.js' ]
scripts: [ 'content/scripts/idleHandler.js' ],
persistent: false
},
content_scripts: [
{
Expand Down

2 comments on commit 23203e1

@diracdeltas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sync client in the feature/syncing branch is implemented as a background script and doesn't work with this change. i will look into why

@bbondy
Copy link
Member Author

@bbondy bbondy commented on 23203e1 Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to just remove it, it was worth a try but it's not important.

Please sign in to comment.