Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Merge pull request #6574 from jide/rootid
Browse files Browse the repository at this point in the history
Rename React root div from windowContainer to appContainer
  • Loading branch information
bbondy authored Jan 28, 2017
2 parents 4fe1205 + 5571daa commit 24ebbf1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/extensions/brave/index-dev.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<link rel="localization" href="locales/{locale}/downloads.properties">
</head>
<body>
<div id="windowContainer">
<div id="appContainer">
<div id="webpackLoading" style="display:none">
<p>
<span>Loading...</span>
Expand Down
2 changes: 1 addition & 1 deletion app/extensions/brave/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<link rel="localization" href="locales/{locale}/downloads.properties"/>
</head>
<body>
<div id="windowContainer"/>
<div id="appContainer"/>
</body>

</html>
2 changes: 1 addition & 1 deletion js/entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,5 @@ ipc.on(messages.INITIALIZE_WINDOW, (e, disposition, appState, frames, initWindow
appStoreRenderer.state = Immutable.fromJS(appState)
ReactDOM.render(
<Window includePinnedSites={disposition !== 'new-popup'} frames={frames} initWindowState={initWindowState} />,
document.getElementById('windowContainer'))
document.getElementById('appContainer'))
})
1 change: 1 addition & 0 deletions less/window.less
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ html,
}
}

#appContainer,
#windowContainer {
width: 100%;
height: 100%;
Expand Down

0 comments on commit 24ebbf1

Please sign in to comment.