Merge pull request #8393 from NejcZdovc/redux/unmount

Removes last check when component is unmounting
brave · Apr 24, 2017 · 506036e · 506036e
2 parents 2212b33 + f4f11a3
commit 506036e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/renderer/components/reduxComponent.js b/app/renderer/components/reduxComponent.js
@@ -19,10 +19,11 @@ class ReduxComponent extends ImmutableComponent {
     this.componentType = props.componentType
     this.state = buildPropsImpl(props, this.componentType)
     this.checkForUpdates = this.checkForUpdates.bind(this)
+    this.dontCheck = false
   }
 
   checkForUpdates () {
-    if (this.shouldComponentUpdate(this.props, this.buildProps())) {
+    if (!this.dontCheck && this.shouldComponentUpdate(this.props, this.buildProps())) {
       this.forceUpdate()
     }
   }
@@ -33,6 +34,7 @@ class ReduxComponent extends ImmutableComponent {
   }
 
   componentWillUnmount () {
+    this.dontCheck = true
     appStore.removeChangeListener(this.checkForUpdates)
     windowStore.removeChangeListener(this.checkForUpdates)
   }