Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fix test failure for notification prompt
Browse files Browse the repository at this point in the history
There is a race condition with titlemode caused by navigating to about:newtab where it remains in urlbar mode.  But the purpose of this test isn't to handle that, and navigating to about:newtab is not commonly done by users. So just adjusting the test to avoid that

Auditors: @diracdeltas
  • Loading branch information
bbondy committed Nov 18, 2016
1 parent c63f9e8 commit 5e36e37
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/components/notificationBarTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('notificationBar', function () {
})
yield this.app.client
.tabByIndex(0)
.loadUrl(Brave.newTabUrl)
.loadUrl(Brave.server.url('page1.html'))
yield this.app.client
.loadUrl(this.notificationUrl)
.windowByUrl(Brave.browserWindowUrl)
Expand Down

1 comment on commit 5e36e37

@diracdeltas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Please sign in to comment.