Handle typing over selected suggestions

Auditors: @aekeus

This fixes the failing test: On suggestion mouseover, appends autocomplete URLs without interrupting typing

Fix #5582

js/components/urlBar.js

@@ -260,13 +260,27 @@ class UrlBar extends ImmutableComponent {
     this.searchSelectEntry = null
   }
 
+  get suggestionLocation () {
+    const selectedIndex = this.activeFrame.getIn(['navbar', 'urlbar', 'suggestions', 'selectedIndex'])
+    if (typeof selectedIndex === 'number') {
+      const suggestion = this.activeFrame.getIn(['navbar', 'urlbar', 'suggestions', 'suggestionList', selectedIndex - 1])
+      if (suggestion) {
+        return suggestion.location
+      }
+    }
+  }
+
   onChange (e) {
     const oldActivateSearchEngine = this.activateSearchEngine
     const oldSearchSelectEntry = this.searchSelectEntry
 
     this.clearSearchEngine()
     this.detectSearchEngine(e.target.value)
 
+    if (this.suggestionLocation) {
+      windowActions.setUrlBarSuggestions(undefined, null)
+    }
+
     // TODO: activeSearchEngine and searchSelectEntry should be stored in
     // state so we don't have to do this hack.
     // It comes into play because no keyUp state changes happen when
@@ -362,12 +376,8 @@ class UrlBar extends ImmutableComponent {
           !this.isActive && !this.isFocused) {
         this.urlInput.value = this.locationValue
       } else if (this.isActive) {
-        const selectedIndex = this.activeFrame.getIn(['navbar', 'urlbar', 'suggestions', 'selectedIndex'])
-        if (typeof selectedIndex === 'number') {
-          const suggestion = this.activeFrame.getIn(['navbar', 'urlbar', 'suggestions', 'suggestionList', selectedIndex - 1])
-          if (suggestion) {
-            this.urlInput.value = suggestion.location
-          }
+        if (this.suggestionLocation) {
+          this.urlInput.value = this.suggestionLocation
         }
       }
     }