Merge pull request #13873 from TheKinshu/issue12569

Fixes Audio indicator if tab muted and video stops playing
brave · May 7, 2018 · d8438b3 · d8438b3
2 parents ed7b2b4 + b9b5c24
commit d8438b3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/app/common/state/tabContentState/audioState.js b/app/common/state/tabContentState/audioState.js
@@ -49,6 +49,10 @@ module.exports.showAudioTopBorder = (state, frameKey, isPinned) => {
     return false
   }
 
+  if (module.exports.isAudioMuted(state, frameKey)) {
+    return false
+  }
+
   return (
     module.exports.canPlayAudio(state, frameKey) &&
     (isEntryIntersected(state, 'tabs') || isPinned)

diff --git a/test/unit/app/common/state/tabContentStateTest/audioStateTest.js b/test/unit/app/common/state/tabContentStateTest/audioStateTest.js
@@ -160,5 +160,13 @@ describe('audioState unit tests', function () {
       const result = audioState.showAudioTopBorder(state, frameKey, false)
       assert.equal(result, false)
     })
+
+    it('return false if tab audio is mute and not pinned', function * () {
+      const state = defaultState
+        .setIn(['frames', index, 'audioPlayback'], true)
+        .setIn(['frames', index, 'audioMuted'], true)
+      const result = audioState.showAudioTopBorder(state, frameKey, false)
+      assert.equal(result, false)
+    })
   })
 })