Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fix bookmark hanger dialog overflow
Browse files Browse the repository at this point in the history
Close #8634

Auditors:

Test Plan:
1. Change UI scale on about:preferences#advanced
2. Minimize the window size
3. Click the star icon
4. Make sure the hanger dialog is not broken

Test Plan 2:
1. Open about:autofill
2. Click "Add Address"
3. Make sure the autofill dialog is not broken
  • Loading branch information
Suguru Hirahara committed May 3, 2017
1 parent 8745bd5 commit ddd069b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions app/renderer/components/common/commonForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ const styles = StyleSheet.create({
cursor: 'default',
width: '100%',
maxWidth: globalStyles.spacing.dialogWidth,
minWidth: '310px',
height: 'auto',
maxHeight: '100vh', // #8634: commonStyles.flyoutDialog,
userSelect: 'none'

// Need a general solution
Expand All @@ -159,6 +162,7 @@ const styles = StyleSheet.create({

commonFormBookmarkHanger: {
maxWidth: globalStyles.spacing.bookmarkHangerMaxWidth,
height: 'initial', // #8634

// Cancel the inherited value from .navbarMenubarFlexContainer, which is 'nowrap'.
whiteSpace: 'normal'
Expand Down

0 comments on commit ddd069b

Please sign in to comment.