replace classList with dataset for bookmarksOverflowIndicator

Fix #10443 Auditors: @luixxiul, @bsclifton
brave · Aug 11, 2017 · fce5ebf · fce5ebf
1 parent d5a6317
commit fce5ebf
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/app/renderer/components/common/contextMenu/contextMenuItem.js b/app/renderer/components/common/contextMenu/contextMenuItem.js
@@ -14,6 +14,7 @@ const windowActions = require('../../../../../js/actions/windowActions')
 // Utils
 const cx = require('../../../../../js/lib/classSet')
 const {formatAccelerator} = require('../../../../common/lib/formatUtil')
+const {elementHasDataset} = require('../../../../../js/lib/eventUtil')
 
 class ContextMenuItem extends ImmutableComponent {
   componentDidMount () {
@@ -94,11 +95,11 @@ class ContextMenuItem extends ImmutableComponent {
 
     if (this.hasSubmenu) {
       let node = e.target
-      while (node && node.classList && !node.classList.contains('contextMenuItem')) {
+      while (node && elementHasDataset(node, 'contextMenuItem')) {
         node = node.parentNode
       }
       let parentNode = node.parentNode
-      while (parentNode && parentNode.classList && !parentNode.classList.contains('contextMenu')) {
+      while (parentNode && !elementHasDataset(parentNode, 'contextMenu')) {
         parentNode = parentNode.parentNode
       }
       const parentBoundingRect = parentNode.getBoundingClientRect()