Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[hackerone] https://hackerone.com/reports/255991 #10270

Closed
diracdeltas opened this issue Aug 3, 2017 · 2 comments · Fixed by #10346
Closed

[hackerone] https://hackerone.com/reports/255991 #10270

diracdeltas opened this issue Aug 3, 2017 · 2 comments · Fixed by #10346
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude security
Milestone
0.18.23 Hotfix

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Aug 3, 2017 •
edited by luixxiul
Loading

Test plan

#10346 (comment)

https://hackerone.com/reports/255991
@diracdeltas diracdeltas added this to the 0.19.x (Beta Channel) milestone Aug 3, 2017
@diracdeltas diracdeltas self-assigned this Aug 3, 2017
@diracdeltas
Copy link
Member Author

related #6098

diracdeltas added a commit that referenced this issue Aug 9, 2017
@diracdeltas
Fix URL parsing consistency issue
3e0de0f 
Fix #10270 by preferring muon.url.parse over Node's legacy (and non-standards compliant) URL parser. This is subobtimal because unit tests are running a different URL parser from the actual browser, but seems like the best trade off for now.

Test Plan:
1. go to brave.com and disable shields
2. go to http://brave.com%60x.code-fu.org/. shields should not be disabled.
@diracdeltas diracdeltas mentioned this issue Aug 9, 2017
Merged
8 tasks
@bbondy bbondy modified the milestones: 0.18.x Hotfix, 0.19.x (Beta Channel) Aug 10, 2017
@luixxiul
Copy link
Contributor

note: release-notes/include has been added to #6098

This was referenced Aug 10, 2017
Closed
Closed
Closed
Closed
This was referenced Aug 11, 2017
Closed
Closed
Closed
diracdeltas added a commit that referenced this issue Aug 15, 2017
@diracdeltas
Add test for #10270
7c4d55b 
Test Plan:
N/A
diracdeltas added a commit that referenced this issue Aug 16, 2017
@diracdeltas
Add test for #10270
139bf08 
Test Plan:
N/A
This was referenced Aug 16, 2017
Closed
Closed
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@diracdeltas @dfperry5
Fix URL parsing consistency issue
d36a1c4 
Fix brave#10270 by preferring muon.url.parse over Node's legacy (and non-standards compliant) URL parser. This is subobtimal because unit tests are running a different URL parser from the actual browser, but seems like the best trade off for now.

Test Plan:
1. go to brave.com and disable shields
2. go to http://brave.com%60x.code-fu.org/. shields should not be disabled.
bsclifton added a commit that referenced this issue Sep 4, 2017
@bsclifton
Merge pull request #10487 from brave/test/more-urlparse
83c87c4 
Add test for #10270
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude security
Projects
None yet
Milestone
0.18.23 Hotfix
Development

Successfully merging a pull request may close this issue.

Fix URL parsing consistency issue brave/browser-laptop
5 participants
@diracdeltas @bbondy @luixxiul @srirambv @LaurenWags