Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

do not show loading icon for about pages #10303

Closed
cezaraugusto opened this issue Aug 4, 2017 · 3 comments · Fixed by #10304
Closed

do not show loading icon for about pages #10303

cezaraugusto opened this issue Aug 4, 2017 · 3 comments · Fixed by #10304
Assignees
@cezaraugusto
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Aug 4, 2017 •
edited by bsclifton
Loading

Test plan

  1. Visit several about pages (about:preferences, about:blank, about:newtab, etc)
  2. Ensure you don't see a loading icon in the tab

Original issue details

about pages are expected to be fast and load instantly and having a loading icon is unnecessary and cause perf junk.
@cezaraugusto cezaraugusto added this to the 0.21.x (Nightly Channel) milestone Aug 4, 2017
@cezaraugusto cezaraugusto self-assigned this Aug 4, 2017
cezaraugusto added a commit that referenced this issue Aug 4, 2017
@cezaraugusto
do not show up loading icon for about pages
2afb9a2 
Auditors: @bsclifton
fix #10303
@cezaraugusto cezaraugusto mentioned this issue Aug 4, 2017
Merged
@mursalal
Copy link

mursalal commented Aug 5, 2017 •
edited
Loading

Hello! Please add user manager, so that all users have own cookies. Then the password manager will not be needed. All password managers working bad.

@cndouglas cndouglas mentioned this issue Aug 7, 2017
Closed
@cndouglas
Copy link

@mursalal I opened a separate issue: #10324

@bsclifton
Copy link
Member

Steps added
cc: @cezaraugusto

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@cezaraugusto @dfperry5
do not show up loading icon for about pages
e74dabf 
Auditors: @bsclifton
fix brave#10303
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

do not show up loading icon for about pages brave/browser-laptop
8 participants
@bbondy @luixxiul @cezaraugusto @bsclifton @mursalal @srirambv @cndouglas @LaurenWags