Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave.com should be able to detect if you visit using Brave #10329

Closed
bsclifton opened this issue Aug 7, 2017 · 2 comments
Closed

Brave.com should be able to detect if you visit using Brave #10329

bsclifton opened this issue Aug 7, 2017 · 2 comments
Assignees
@bsclifton
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@bsclifton
Copy link
Member

bsclifton commented Aug 7, 2017 •
edited
Loading

Test plan

Steps to test manually (I ran and verified it works fine)

  1. Launch Brave and visit https://brave.com
  2. Open the developer tools (F12 or shift + option + i)
  3. Force reload the page (shift + cmd + R or shift + ctrl + R)
  4. Inspect the network tab for the brave.com resource
  5. Under request headers, you should see the user agent (Brave being the important part):
    "user-agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Brave Chrome/59.0.3071.115 Safari/537.36"

Original issue description

request per @too4words:
Instead of prompting user with "Download Brave" we may instead show "Thank you for using Brave"

In order to do this, we'd need a way to detect the browser is Brave (via user agent string)
@bsclifton bsclifton added this to the 0.21.x (Nightly Channel) milestone Aug 7, 2017
@bsclifton bsclifton self-assigned this Aug 7, 2017
@bsclifton bsclifton mentioned this issue Aug 7, 2017
Merged
8 tasks
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@bsclifton @dfperry5
Update user-agent whitelist to include brave.com
3c0afc2 
Fixes brave#10329

Auditors: @too4words, @bradleyrichter
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@srirambv
Copy link
Collaborator

Works on Windows
image

@LaurenWags
Copy link
Member

MacOS:
screen shot 2017-12-21 at 5 11 57 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @bsclifton @srirambv @LaurenWags