You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Describe the issue you encountered: Remove LESS files from js/about/styles.js to make it possible to confirm how components should look by default.
There are some cases where components' styles are overridden by specifications on LESS files (such as preferences.less). It makes hard to find what should be converted, replaced and refactored if necessary. Removing the LESS files from that file will also help us to detect visual regressions and fix them if any.
Platform (Win7, 8, 10? macOS? Linux distro?): All
Brave Version (revision SHA): master branch
Extra QA steps:
Open about:styles
Any related issues:
The text was updated successfully, but these errors were encountered:
Closesbrave#10459
Auditors: @cezaraugusto
Test Plan:
1. Open about:styles
2. Make sure the page is rendered (you do not have to search for regressions)
Describe the issue you encountered: Remove LESS files from
js/about/styles.js
to make it possible to confirm how components should look by default.There are some cases where components' styles are overridden by specifications on LESS files (such as
preferences.less
). It makes hard to find what should be converted, replaced and refactored if necessary. Removing the LESS files from that file will also help us to detect visual regressions and fix them if any.Platform (Win7, 8, 10? macOS? Linux distro?): All
Brave Version (revision SHA): master branch
Extra QA steps:
about:styles
Any related issues:
The text was updated successfully, but these errors were encountered: