Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinned tabs disappear until close/relaunch #10510

Closed
LaurenWags opened this issue Aug 15, 2017 · 2 comments · Fixed by #10531
Closed

pinned tabs disappear until close/relaunch #10510

LaurenWags opened this issue Aug 15, 2017 · 2 comments · Fixed by #10531
Labels
bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 15, 2017 •
edited by luixxiul
Loading

Test plan

#10531 (comment)

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Using clean profile, if I pin a couple of sites from new tabs, reorder, and then 'reuse' the about:welcome tab and pin a site, the previously pinned sites disappear until close/relaunch.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    found with 0.18.22, exists in 0.18.14 also.

  • Steps to reproduce:

    1. Clean profile
    2. launch Brave
    3. Don't close or use either of the tabs. Leave as is.
    4. Open a new tab
    5. visit a site
    6. pin the tab
    7. Open another new tab
    8. visit a different site,
    9. pin the tab
    10. Move this tab to the first position.
    11. Click on the about:welcome tab.
    12. Change the URL to a different site.
    13. Pin this tab.
    14. two previously pinned tabs are not displayed.

  • Actual result:
    Previously pinned tabs are not displayed. Must close/relaunch Brave to see them.

  • Expected result:
    Pinned tabs should not disappear.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    missingpinnedtabs

  • Any related issues:
@LaurenWags LaurenWags added this to the 0.21.x (Nightly Channel) milestone Aug 15, 2017
@luixxiul
Copy link
Contributor

duping to #10179?

@petemill
Copy link
Member

Can reproduced when just moving any previously-pinned tabs then creating a new tab, visiting a url and pinning the new tab. All previously-pinned tabs disappears.
Can also reproduce most times when I have more than 7 or so tabs pinned, close and reopen the window, then try to pin a new tab with a different url.

The event app-tab-close-requested is being dispatched so I've been tracing where from. It's been an education in to the flow of the action dispatcher(s) and the browser window ipc communication. Pretty sure that the bug is in updatePinnedTabs in app/browser/window.js. Working on a fix now.

petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
fa9b09b 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
6248c7c 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
This was referenced Aug 16, 2017
Merged
Closed
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 26, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f912e34 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a9443d5 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f9a6772 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 28, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a8e12ab 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
bsclifton pushed a commit to petemill/browser-laptop that referenced this issue Aug 29, 2017
@petemill @bsclifton
Stop losing pinned tabs in a window when adding or removing another p…
01008da 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
6 participants
@petemill @bbondy @luixxiul @bsclifton @srirambv @LaurenWags