Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Window menu on session restore doesn't populate for too long #10568

Closed
bbondy opened this issue Aug 17, 2017 · 2 comments
Closed

Window menu on session restore doesn't populate for too long #10568

bbondy opened this issue Aug 17, 2017 · 2 comments
Labels
muon OS/macOS perf priority/P4 Minor loss of function. Workaround usually present. stale

Comments

@bbondy
Copy link
Member

bbondy commented Aug 17, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    If you have a lot of windows, each containing a lot of tabs, then you close and open the browser, the Window menu should list everything.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    0.18.23

  • Steps to reproduce:

    1. Open several windows each with several tabs
    2. Close Brave
    3. Open Brave
    4. Goto the Window menu
    5. Leave it open and watch
  • Actual result:
    It takes a long time to populate, and maybe doesn't fully populate.
    For Brendan this takes 10-20s on his profile.

  • Expected result:
    Should restore active tab titles from session storage.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    A fresh profile that you build up several windows from, yes.

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

@bbondy bbondy added this to the 0.21.x (Nightly Channel) milestone Aug 17, 2017
@bbondy bbondy added the perf label Aug 17, 2017
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned NejcZdovc Sep 5, 2017
@ghost
Copy link

ghost commented Sep 11, 2017

I am able to reproduce this. Each entry in the 'Window' menu list starts as 'Brave' then is updated to 'about:blank' after a few seconds. Then later as the windows and tabs load the list updates with correct window titles. I didn't notice any missing entries.

Brave 0.18.29
rev 85f059d
Muon 4.3.16
libchromiumcontent 60.0.3112.113
V8 6.0.286.56
Node.js 7.9.0
Update Channel dev
OS Platform macOS
OS Release 16.7.0
OS Architecture x64

@alexwykoff
Copy link
Contributor

@NejcZdovc tested on windows, this is mac only

@alexwykoff alexwykoff added muon priority/P4 Minor loss of function. Workaround usually present. labels Sep 19, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
muon OS/macOS perf priority/P4 Minor loss of function. Workaround usually present. stale
Projects
None yet
Development

No branches or pull requests

4 participants