Tracking: Critical performance tracking issue

[bsclifton]

The goal of this issue is to track our most painful performance impacting issues

General slowness

• page load tracking issue Performance : 0.13.0 page load tracking issue #6836
• Findbar slowness (cmd + F, typing) Findbar slowness (cmd + F, typing) #10271
• Application slowness (when opening new tabs, loading a website) Application slowness (when opening new tabs, loading a website) #8541
• new-tab URL bar blocked for ~12ms UX: new-tab URL bar blocked for ~12ms #12130
• Context menu is slow when you have a lot of bookmarks Context menu bookmarks #10054
• Ledger getPublisher perf is bad even if ledger is off Ledger getPublisher perf is bad even if ledger is off #10186
• Browser freezes per 5 minutes with existing profile Browser freezes per 5 minutes with existing profile #10094
• Window restore Window menu on session restore doesn't populate for too long #10568
• component mergeProps are unnecessarily running component mergeProps are unnecessarily running #11515

Tab switching slowness

• In siteUtil.updateSiteFavicon use location cache In siteUtil.updateSiteFavicon use location cache #9279
• Tab update events should only fire when data has changed muon#208 (browser-laptop Tab update events happen when there are no tab updates #9313)
• When pages are unloaded, or loading, and switching to them

URL bar

• Focus URL bar (cmd + L) and type cmd + l appears to be dropping input on urlbar #7358
• Findbar slowness and losing of characters (cmd + F, typing) Findbar slowness and losing of characters (cmd + F, typing) #10606
• Address field performance is really bad Address field performance is really bad #6620
• New tab (cmd + T) and type
• Browser freezes when typing in URL bar Browser freezes when typing in URL bar #11066

Tab close speed

• Brave Browser very slow to open or close tabs Brave Browser very slow to open or close tabs #4848

Page navigation

• When pages are loaded browser doesn't accept user input (event storm?)
• isResourceEnabled checks #9987
• appState.sites sort takes a long time (Every navigation +200 ms [w/ 10K bookmarks]) appState.sites sort takes a long time (Every navigation +200 ms [w/ 10K bookmarks]) #9427
• pages which create multiple entries on visit History list shows unnecessary duplicates for same-page actions (like google maps) #3848

About pages

• Use bloodhound for about:bookmarks
• Query bloodhound for about:history

Worker threads

• Enable worker threads for ledger Enable worker threads for ledger #9222
• Generate URL suggestions in a worker thread Generate URL suggestions in a worker thread #10187

Auditing / instrumentation

• performance auditing using Lighthouse performance auditing using Lighthouse #9719
• Automated performance tests Automated performance tests #10115

Bookmark / sites related

• Editing a bookmark (or folder) locks up the browser Editing a bookmark (or folder) locks up the browser #9674
• Bookmarks should have only primitives Only primitives in BookmarksToolbar and BookmarkToolbarButton #9712
• Split sites in the app state Split sites into separate entities. #9978
• link hover causes re-render move frame hrefPreview to a separate component  #10194

Reflows

• Audit DOM APIs that do layout reflows Audit DOM APIs that do layout reflows #10027

Slow startup time

• Improve startup time Improve startup time #3025 more info here

Battery life

• GPU-related high battery use on MacBook Pro with Touch Bar GPU-related high battery use on MacBook Pro with Touch Bar #6443

[ayumi]

Tab switching slowness should be improved by brave/muon#208 (browser-laptop #9313).

[bsclifton]

@ayumi awesome! We're currently on 4.0.0 which doesn't have the fix... so we'll need a new build. The work you did with #9279 helps a great deal if the tab isn't loaded yet (ex: after you open browser OR if tab is unloaded due to tab discarding)

[ayumi]

I've been experiencing an intense browser UI / chrome slowness (browser with 3K bookmarks):

I have a bookmarks toolbar with stuff in it, and when I hover over it takes 2000 ms before buttons get the hover effect (highlighting to suggest clickability). Tabs lag similarly.
This slowness doesn't appear to be in the reducers.

[NejcZdovc]

@ayumi on the master or 0.17? for master (0.19) this PR should fix perf problems #9713

[ayumi]

@NejcZdovc On both master (0562bf4) and the current preview release.

Happening just on master (0562bf4).

[NejcZdovc]

for master I have a PR up, but for the current release it's not relevant, because we merged redux for bookmarks in 0.19

[ayumi]

@NejcZdovc Sorry I checked again and the latest preview is okay ( 0.17.13 rev f7242c7) – the UI slowness was just in master.

[NejcZdovc]

Make sense, so that PR should fix this slowness. It's already done, but we want to improve one more thing

[bsclifton]

Most (if not all) of these issues should be addressed with brave-core

For folks that want to try specific issues with an experimental release of our new product, you can download a recent release and try it out:
https://github.com/brave/brave-browser/releases