Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark toolbar tests are failing #10822

Closed
NejcZdovc opened this issue Sep 6, 2017 · 1 comment
Closed

Bookmark toolbar tests are failing #10822

NejcZdovc opened this issue Sep 6, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
automated-tests feature/bookmarks QA/no-qa-needed release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:

4) bookmarksToolbar configuration settings shows the bookmarks toolbar if the setting is enabled:
     element ("[data-test-id="bookmarksToolbar"]") still not visible after 10000ms
  Error

  5) bookmarksToolbar when clicking a bookmark folder shows a context menu:
     Error: element ("[data-test-id="bookmarksToolbar"]") still not visible after 10000ms
      at elements("[data-test-id="bookmarksToolbar"]") - isVisible.js:54:17
      at isVisible("[data-test-id="bookmarksToolbar"]") - waitForVisible.js:73:22

  6) bookmarksToolbar when clicking a bookmark folder automatically opens context menu if you move mouse over a different folder:
     Error: element ("[data-test-id="bookmarksToolbar"]") still not visible after 10000ms
      at elementIdDisplayed("0.9216090270715052-2") - isVisible.js:71:55

  7) bookmarksToolbar when clicking a bookmark folder hides context menu when mousing over regular bookmark:
     Error: element ("[data-test-id="bookmarksToolbar"]") still not visible after 10000ms
      at elements("[data-test-id="bookmarksToolbar"]") - isVisible.js:54:17
      at isVisible("[data-test-id="bookmarksToolbar"]") - waitForVisible.js:73:22

  8) bookmarksToolbar display favicon on bookmarks toolbar display bookmark favicon for url that has it:
     Error: element ("[data-test-id="bookmarksToolbar"]") still not visible after 10000ms
      at elements("[data-test-id="bookmarksToolbar"]") - isVisible.js:54:17
      at isVisible("[data-test-id="bookmarksToolbar"]") - waitForVisible.js:73:22

  9) bookmarksToolbar display favicon on bookmarks toolbar fallback to default bookmark icon when url has no favicon:
     Error: element ("[data-test-id="bookmarksToolbar"]") still not visible after 10000ms
      at elements("[data-test-id="bookmarksToolbar"]") - isVisible.js:54:17
      at isVisible("[data-test-id="bookmarksToolbar"]") - waitForVisible.js:73:22
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 6, 2017
@NejcZdovc
Copy link
Contributor Author

This was broken with #10512

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 6, 2017
@NejcZdovc
Fixes bookmarksToolbar webdriver tests
76f6502 
Resolves brave#10822

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 6, 2017
Merged
8 tasks
NejcZdovc added a commit that referenced this issue Sep 6, 2017
@NejcZdovc
Merge pull request #10823 from NejcZdovc/tests/#10822-bookmark
314897b 
Fixes bookmarksToolbar webdriver tests
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests feature/bookmarks QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
3 participants
@bbondy @luixxiul @NejcZdovc