Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark toolbar is not hidden if you disable it #10828

Closed
NejcZdovc opened this issue Sep 6, 2017 · 1 comment
Closed

Bookmark toolbar is not hidden if you disable it #10828

NejcZdovc opened this issue Sep 6, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
automated-tests feature/bookmarks QA/no-qa-needed release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:

  19) navigationBar tests auto open bookmarks toolbar for the first bookmark should remain hidden if user has bookmarks but has toolbar hidden:
     Promise was rejected with the following reason: timeout
  Error
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 6, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes bookmark hanger displaying bookmark toolbar when disabled
f11aebc 
Resolves brave#10828

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Sep 7, 2017
@NejcZdovc NejcZdovc mentioned this issue Sep 7, 2017
Merged
8 tasks
@NejcZdovc
Copy link
Contributor Author

this was broken with #9710, so that's why I am setting this one to 0.19.x

NejcZdovc added a commit that referenced this issue Sep 7, 2017
@NejcZdovc
Merge pull request #10837 from NejcZdovc/hotfix/#10828-hanger
5c7ca8a 
Fixes bookmark hanger displaying bookmark toolbar when disabled
NejcZdovc added a commit that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes bookmark hanger displaying bookmark toolbar when disabled
074e23d 
Resolves #10828

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes bookmark hanger displaying bookmark toolbar when disabled
0d76c1c 
Resolves #10828

Auditors:

Test Plan:
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests feature/bookmarks QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
2 participants
@luixxiul @NejcZdovc