Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

notifications are not honouring users "Remember this decision" #10957

Closed
kjozwiak opened this issue Sep 14, 2017 · 1 comment
Closed

notifications are not honouring users "Remember this decision" #10957

kjozwiak opened this issue Sep 14, 2017 · 1 comment

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 14, 2017

- Did you search for similar issues before submitting this one?

Yes

- Describe the issue you encountered:

Notifications are not honouring the users decision and will always prompt for permission even though "Remember this decision" has been selected. If you take a look at about:preferences#security, you can also see the decision being listed but not being honoured.

- Platform (Win7, 8, 10? macOS? Linux distro?):

Ubuntu 17.04 x64 - Reproduced
macOS 10.12.6 x64 - Reproduced
Win 10 Pro x86 - Reproduced
Win 10 Pro x64 - Reproduced

- Brave Version (revision SHA):

Brave: 0.18.35 rev: 7181ba3
Muon: 4.3.22
libchromiumcontent: 61.0.3163.79

- Steps to reproduce:

  1. Open Brave and visit https://browserleaks.com/geo
  2. Once you get the notification, select "Remember my decision" and select "Allow"
  3. Check about:preferences#security and you'll see the decision being correctly listed
  4. Revisit the same page and you'll be prompted again

- Actual result:

"Remember my decision" not working and the permission notification will appear every single time.

- Expected result:

"Remember my decision" should honour the users decision.

- Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

- Is this an issue in the currently released version?

No, this is a new regression

- Can this issue be consistently reproduced?

Yes, 100% using the above STR.

Example if issue:

issue

bbondy added a commit that referenced this issue Sep 14, 2017
Already covered by this test:
```
1) notificationBar permissions can accept permission request
persistently:
     Promise was rejected with the following reason: timeout
```

Fix #10957
bbondy added a commit that referenced this issue Sep 14, 2017
Already covered by this test:
```
1) notificationBar permissions can accept permission request
persistently:
     Promise was rejected with the following reason: timeout
```

Fix #10957
bbondy added a commit that referenced this issue Sep 14, 2017
Already covered by this test:
```
1) notificationBar permissions can accept permission request
persistently:
     Promise was rejected with the following reason: timeout
```

Fix #10957
bbondy added a commit that referenced this issue Sep 14, 2017
Already covered by this test:
```
1) notificationBar permissions can accept permission request
persistently:
     Promise was rejected with the following reason: timeout
```

Fix #10957
@kjozwiak
Copy link
Member Author

Used http://permission.site/ as another useful site to make sure notification decisions are being remembered and honoured.

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Already covered by this test:
```
1) notificationBar permissions can accept permission request
persistently:
     Promise was rejected with the following reason: timeout
```

Fix brave#10957
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.