Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor dropdown component #11063

Closed
luixxiul opened this issue Sep 21, 2017 · 0 comments
Closed

Refactor dropdown component #11063

luixxiul opened this issue Sep 21, 2017 · 0 comments
Assignees
@luixxiul
Labels
polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite refactoring release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 21, 2017 •
edited
Loading

Test plan

#11064 (comment)

Description

Polish dropdown.js

  • Remove dropdown components only used on certain cases, ie. CommonFormFullWidthDropdown, PanelDropdown, and BraveryPanelDropdown.
  • Add data attributions to replace those components.

Additional Information
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Sep 21, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 21, 2017
@luixxiul luixxiul self-assigned this Sep 21, 2017
@luixxiul luixxiul mentioned this issue Sep 21, 2017
Merged
8 tasks
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Reorganize dropdown.js
8f2dbd5 
Closes brave#11063

- Replace specific components with ones styled with data attirbutions

Auditors:

Test Plan:
1. Open about:styles
2. Click `dropdowns`
3. Make sure they are properly styled
4. Open about:autofill
5. Click `Add Address`
6. Make sure the country dropdown has 100% width
This was referenced Dec 20, 2017
Closed
Closed
@bsclifton bsclifton changed the title Polish dropdown.js Refactor dropdown component Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite refactoring release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @bsclifton @srirambv @LaurenWags