This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
browserButton should have -webkit-app-region: no-drag by default #11111
Assignees
Labels
misc/button
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Milestone
Comments
luixxiul
added
misc/button
polish
8 tasks
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Closes brave#11111 Requires brave#10951 to make the shield button non-draggable Auditors: @cezaraugusto Test Plan: 1. Open brave.com 2. Enable NoScript 3. Enable an extension 4. Make sure NoScript button, the extension button, and publisher button is not draggable
This was referenced Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#11110 (comment)
Description
browserButton should be explicitly specified with
-webkit-app-region: no-drag(which is the default value for buttons) to overwrite an inherited value, especially on the navigation bar.Steps to Reproduce
Actual result:
NoScript button (which is currently span element), extension button, shield button, publisher button's container are specified with no-drag individually.
Expected result:
browserButtonshould be speficied with-webkit-app-region: no-drag.Reproduces how often: [What percentage of the time does it reproduce?]
Additional Information
Requires #10951 to make the shield button non-draggable
The text was updated successfully, but these errors were encountered: