Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger table data is not cleared properly #11278

Closed
LaurenWags opened this issue Oct 4, 2017 · 2 comments
Closed

ledger table data is not cleared properly #11278

LaurenWags opened this issue Oct 4, 2017 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Ledger table data is not cleared properly when clearing Browser History with Payments Disabled.

Steps to Reproduce

  1. Have a ledger with some entries (some included, some not included).
  2. Note views/amt of time spent for a couple of sites.
  3. Disable payments.
  4. Go to about:preferences#security, click on Clear Browsing Data Now, enable toggle for
  5. Browser History, click Clear
  6. Enable payments.
  7. Table is blank as expected.
  8. Visit one of the sites you noted that was marked as include.
  9. Note as soon as the page loads (prior to default value of 8s) your URL heart icon is yellow indicating it is in the table.
  10. Go back to Payments (you might have to refresh due to another issue)
  11. Your site is listed in the table with similar visit#/time spent as prior to clearing data. I was expecting the counters to start over.
  12. Repeat with another site that had been in the table prior to clearing Browser History. You will see a similar result.

Actual result:
ledgernotrestartingat0

Expected result:
Since table data had been cleared, I was expecting the number of visits and time spent counters to reset. The amount of time of the gif above is less than 1.5 minutes, so it's not possible that I spent 4+ minutes on brianbondy.com and 2+ minutes on thepioneerwoman.com.

Reproduces how often: [What percentage of the time does it reproduce?] 100% for me

Brave Version

about:brave info:
Brave | 0.19.28
rev | 08781a5
Muon | 4.4.25

Reproducible on current live release:
no

Additional Information

Reproduced by @srirambv on Windows
cc @kjozwiak

Ledger table data prior to clearing browsing history:
screen shot 2017-10-04 at 2 27 30 pm

Ledger table data after clearing browsing history and visiting two of the above sites. They're readded and retain some of the previous data:
screen shot 2017-10-04 at 2 43 10 pm

@LaurenWags LaurenWags added this to the 0.19.x (Beta Channel) milestone Oct 4, 2017
@bsclifton bsclifton self-assigned this Oct 4, 2017
@bsclifton bsclifton added the priority/P4 Minor loss of function. Workaround usually present. label Oct 4, 2017
@srirambv
Copy link
Collaborator

srirambv commented Oct 5, 2017

Should ledger table be removed when browser data is cleared with payments disabled? @NejcZdovc

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 5, 2017

@srirambv yes this is the current workflow

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bsclifton Oct 5, 2017
NejcZdovc added a commit that referenced this issue Oct 5, 2017
NejcZdovc added a commit that referenced this issue Oct 6, 2017
Fixes clear  #11278
Fixes default monthly budget
NejcZdovc added a commit that referenced this issue Oct 6, 2017
Fixes clear  #11278
Fixes default monthly budget
NejcZdovc added a commit that referenced this issue Oct 6, 2017
Fixes clear  #11278
Fixes default monthly budget
NejcZdovc added a commit that referenced this issue Oct 6, 2017
Fixes clear  #11278
Fixes default monthly budget
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Fixes clear  brave#11278
Fixes default monthly budget
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants