Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Uncaught TypeError: Cannot read property 'map' of undefined" when clicking on a stacked notification #11282

Closed
kjozwiak opened this issue Oct 5, 2017 · 1 comment

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 5, 2017

Description

When you have two of the same notifications stacked on top of each other from the same origin, dismissing the first one will take a while and give the user the perception that the notification is broken. You'll also get the following stack in the browser console:

Uncaught TypeError: Cannot read property 'map' of undefined app.entry.js:84648 
    at NotificationItem.render (app.entry.js:84648)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (app.entry.js:67075)
    at ReactCompositeComponentWrapper._renderValidatedComponent (app.entry.js:67098)
    at ReactCompositeComponentWrapper._updateRenderedComponent (app.entry.js:67022)
    at ReactCompositeComponentWrapper._performComponentUpdate (app.entry.js:67000)
    at ReactCompositeComponentWrapper.updateComponent (app.entry.js:66921)
    at ReactCompositeComponentWrapper.receiveComponent (app.entry.js:66823)
    at Object.receiveComponent (app.entry.js:19866)
    at ReactCompositeComponentWrapper._updateRenderedComponent (app.entry.js:67030)
    at ReactCompositeComponentWrapper._performComponentUpdate (app.entry.js:67000)

Steps to Reproduce

  1. launch Brave and open https://mail.protonmail.com/
  2. ensure that you have two passwords set in protonmail (one to login, one for the mailbox)
  3. login into protonmail via the username/password fields
  4. enter your mailbox password on the second sreen and you'll have two "Save Password" notifications
  5. click on either "Allow" or "Deny" on the first notification from the top

Actual result:

You'll notice that clicking on "Allow", "Deny" or "Never For This Site" won't have any affects on the first notification.

Expected result:

The first notification should be dismissed as soon as a user clicks on "Allow", "Deny" or "Never For This Site".

Reproduces how often: [What percentage of the time does it reproduce?]

100% reproducible using the STR from above.

Brave Version

about:brave info:

Brave: 0.19.28
rev: 08781a5
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:

Not reproducible under 0.18.36... Looks like a recent regression in 0.19.x

Additional Information

notificationissues

@kjozwiak kjozwiak added this to the 0.19.x (Beta Channel) milestone Oct 5, 2017
@bsclifton bsclifton self-assigned this Oct 5, 2017
@bsclifton bsclifton added the priority/P3 Major loss of function. label Oct 5, 2017
bsclifton added a commit that referenced this issue Oct 5, 2017
Fixes #11282

Auditors: @cezaraugusto, @kjozwiak

Test Plan:
See #11282
(I ran these steps and verified the fix)
bsclifton added a commit that referenced this issue Oct 5, 2017
Fixes #11282

Auditors: @cezaraugusto, @kjozwiak

Test Plan:
See #11282
(I ran these steps and verified the fix)
@bsclifton
Copy link
Member

master 29bdbd5
0.20.x 3e5a98b
0.19.x 44c0311

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Fixes brave#11282

Auditors: @cezaraugusto, @kjozwiak

Test Plan:
See brave#11282
(I ran these steps and verified the fix)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants