This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Tab 'appear' animations run again when tab is moved #11470
Labels
Milestone
Comments
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 13, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
8 tasks
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 13, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 13, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 13, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 16, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 16, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 16, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
cezaraugusto
pushed a commit
that referenced
this issue
Oct 27, 2017
Fix #11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Nov 9, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Fix brave#11470 Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
Moved to milestone 0.22.x due to requiring it for a clean merge of #12565 and the same / similar test plan for that version. |
This was referenced Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Test plan
#11501 (comment)
Description
Tab 'appear' animations run again when tab element is moved via a new sort order.
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often: always
Brave Version
master, introduced in 33c5d10 for issue #10883 and PR
Test Plan
From PR #10691 / issue #10883 (create smooth transitions for tab components)
Resolving this issue
The text was updated successfully, but these errors were encountered: