Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add funds dialog shows up even if I have BAT already #12078

Closed
Alino opened this issue Nov 23, 2017 · 8 comments
Closed

add funds dialog shows up even if I have BAT already #12078

Alino opened this issue Nov 23, 2017 · 8 comments
Assignees
@NejcZdovc
Labels
0.19.x issue first seen in 0.19.x feature/rewards initiative/bat-payments priority/P4 Minor loss of function. Workaround usually present. QA/test-plan-specified release-notes/include
Milestone
0.19.x Hotfix 7 (...

Comments

@Alino
Copy link

Alino commented Nov 23, 2017 •
edited by bsclifton
Loading

Test plan

See #12154

Original issue description

v0.19.95

I got this message from time to time
image

even though if I click on add funds button, I do have some BAT in the brave wallet
image
@luixxiul luixxiul added 0.19.x issue first seen in 0.19.x feature/rewards labels Nov 23, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@disfit
Copy link

disfit commented Nov 28, 2017

I can confirm this behavior and am using the same version (0.19.95 on linux). For me it popped up one or two days before my contribution was due.

@disfit disfit mentioned this issue Nov 28, 2017
Closed
@bsclifton bsclifton added the priority/P4 Minor loss of function. Workaround usually present. label Nov 28, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Backlog (Prioritized) Nov 28, 2017
@disfit
Copy link

disfit commented Nov 28, 2017

Adding screenshot since it happened again as further confirmation:

screenshot from 2017-11-28 20-12-11

@LaurenWags
Copy link
Member

+1 reproduced on 0.19.104 (using Staging Payments Server). Here are my steps:
Clean profile. Enabled payments. Visited some sites so that I have ledger entries. Funded wallet. Closed Brave. Updated reconcileStamp. Launched Brave again, waited for contribution to be made and saw this instead.

screen shot 2017-11-30 at 5 25 10 pm

@NejcZdovc NejcZdovc self-assigned this Dec 1, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 1, 2017
@NejcZdovc
Fixes add founds dialog
4425b4a 
Resolves brave#12078

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Dec 1, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 1, 2017
@NejcZdovc
Fixes add founds dialog
02fd0e6 
Resolves brave#12078

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 1, 2017
@NejcZdovc
Fixes add founds dialog
5d306aa 
Resolves brave#12078

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.19.x Hotfix 7 (Release channel) Dec 1, 2017
@eljuno
Copy link
Contributor

eljuno commented Dec 3, 2017

+1 from community https://community.brave.com/t/bogus-account-waiting-for-a-deposit-notification/11555?u=eljuno

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 4, 2017
@NejcZdovc
Fixes add founds dialog
10f4d8d 
Resolves brave#12078

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Dec 5, 2017
@NejcZdovc @bsclifton
Fixes add founds dialog
0d3d087 
Resolves brave#12078

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Dec 5, 2017
@bsclifton
Merge pull request #12154 from NejcZdovc/hotfix/#12078-funds
8c3ef5e 
Fixes add funds dialog
bsclifton added a commit that referenced this issue Dec 5, 2017
@bsclifton
Merge pull request #12154 from NejcZdovc/hotfix/#12078-funds
9a3ced4 
Fixes add funds dialog
bsclifton added a commit that referenced this issue Dec 5, 2017
@bsclifton
Merge pull request #12154 from NejcZdovc/hotfix/#12078-funds
893bfa4 
Fixes add funds dialog
bsclifton added a commit that referenced this issue Dec 5, 2017
@bsclifton
Merge pull request #12154 from NejcZdovc/hotfix/#12078-funds
7394478 
Fixes add funds dialog
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 7 (Release channel), 0.19.x + C63 (Release Channel) Dec 7, 2017
This was referenced Dec 8, 2017
Closed
Closed
Closed
This was referenced Dec 11, 2017
Closed
Closed
Closed
@bsclifton bsclifton mentioned this issue Dec 11, 2017
Closed
This was referenced Dec 12, 2017
Closed
Closed
@bsclifton bsclifton modified the milestones: 0.19.x + C63 (Release Channel), 0.19.x Private Search Dec 14, 2017
@kjozwiak kjozwiak mentioned this issue Dec 14, 2017
Closed
@Alino
Copy link
Author

Alino commented Jan 4, 2018

this has just reoccurred to me.
version 0.19.123

@LaurenWags LaurenWags reopened this Jan 16, 2018
@LaurenWags
Copy link
Member

This is still being reported with 0.19.134 in Community: https://community.brave.com/t/monthly-budget-tab-still-defaulting-to-25-bat/13461/7

@NejcZdovc NejcZdovc removed this from the 0.19.x Hotfix 7 (Release channel) milestone Jan 17, 2018
@NejcZdovc
Copy link
Contributor

I can't reproduce this with steps in the PR. I will close this one and let's open a new one when we have STR.

@Alino
Copy link
Author

Alino commented Aug 21, 2018

this has just reoccurred to me again.

Name Version
Brave 0.23.79
V8 6.8.275.24
rev 51b4905
Muon 8.0.7
OS Release 17.7.0
Update Channel Release
OS Architecture x64
OS Platform macOS
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 68.0.3440.84

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.19.x issue first seen in 0.19.x feature/rewards initiative/bat-payments priority/P4 Minor loss of function. Workaround usually present. QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 7 (Release channel)
Development

No branches or pull requests
9 participants
@Alino @kjozwiak @luixxiul @bsclifton @NejcZdovc @srirambv @disfit @eljuno @LaurenWags