Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Drag and Drop bookmark from folder on toolbar to Bookmarks Toolbar does not work #12481

Closed
LaurenWags opened this issue Jan 3, 2018 · 4 comments
Closed

Drag and Drop bookmark from folder on toolbar to Bookmarks Toolbar does not work #12481

LaurenWags opened this issue Jan 3, 2018 · 4 comments
Assignees
@NejcZdovc
Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2018 •
edited by bsclifton
Loading

Description

If you drag and drop a bookmark from a folder on the toolbar to the Bookmarks Toolbar, the bookmark should be moved to the toolbar. However, the bookmark remains in the folder.

Test plan / Steps to Reproduce

  1. Clean profile on 0.20.14
  2. Add a folder on the Bookmarks Toolbar.
  3. Add a bookmark to this folder.
  4. Expand the folder from the toolbar.
  5. Attempt to drag and drop the bookmark from the folder onto the Toolbar.

Actual result:
Bookmark is not moved to the toolbar:

dnd-from-toolbar-folder-02014

Expected result:
Bookmark should be moved to the toolbar as it was in 0.19.123:

dnd-from-toolbar-folder-019123

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.14
V8 | 6.3.292.48
rev | 5d75826
Muon | 4.5.33

Reproducible on current live release:
no

Additional Information
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 3, 2018 •
edited
Loading

this one have the same root problem than #12476

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 5, 2018
@NejcZdovc
Fixes dnd for bookmark toolbar
023f4e3 
Resolves brave#12481
Resolves brave#12506

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 5, 2018
Merged
10 tasks
cezaraugusto added a commit that referenced this issue Jan 5, 2018
@cezaraugusto
Merge pull request #12517 from NejcZdovc/hotfix/#12481-dnd
c296032 
Fixes dnd for bookmark toolbar
cezaraugusto added a commit that referenced this issue Jan 5, 2018
@cezaraugusto
Merge pull request #12517 from NejcZdovc/hotfix/#12481-dnd
9202b0b 
Fixes dnd for bookmark toolbar
cezaraugusto added a commit that referenced this issue Jan 5, 2018
@cezaraugusto
Merge pull request #12517 from NejcZdovc/hotfix/#12481-dnd
81346ee 
Fixes dnd for bookmark toolbar
@srirambv
Copy link
Collaborator

srirambv commented Jan 9, 2018

Can't drag the bookmark to toolbar on Windows.
12481

@srirambv srirambv reopened this Jan 9, 2018
@cezaraugusto cezaraugusto mentioned this issue Jan 9, 2018
Closed
@NejcZdovc
Copy link
Contributor

I will close this one, because dnd not working in windows is not related to this PR. Will open another issue for it.

@NejcZdovc NejcZdovc mentioned this issue Jan 10, 2018
Closed
@NejcZdovc
Copy link
Contributor

created new issue #12590

This was referenced Jan 24, 2018
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags