Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

site specific settings for Fingerprinting Protection on are lost when updating to 0.20 #12497

Closed
LaurenWags opened this issue Jan 4, 2018 · 0 comments · Fixed by #12509
Closed

site specific settings for Fingerprinting Protection on are lost when updating to 0.20 #12497

LaurenWags opened this issue Jan 4, 2018 · 0 comments · Fixed by #12509
Assignees
@diracdeltas
Labels
0.20.x issue first seen in 0.20.x bug feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 4, 2018 •
edited by luixxiul
Loading

Test plan

#12509 (comment)

Description

If you have FP on by default in 0.19.123, it is correctly updated to 'Block All' setting in 0.20.14. However, if you have FP off by default in 0.19.123 but have a single site (or sites) set up to have FP enabled, these site settings are lost when updating to 0.20.14.

Steps to Reproduce

  1. Using 0.19.123 verify FP is off by default in about:preferences#shields
  2. Navigate to a site and set FP toggle to on for this site from the shield.
  3. Navigate to about:preferences#shields and verify your site specific setting is displayed under Saved Site Exceptions.
  4. Close Brave and manually update your profile to 0.20.14
  5. Open 0.20.14 and navigate to about:preferences#shields

Actual result:
Your site specific setting is no longer displayed:
screen shot 2018-01-04 at 8 25 27 am

Expected result:
Your site specific setting should still be there and instead of 'On' should say 'Block all fingerprinting'

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.14
V8 | 6.3.292.48
rev | 5d75826
Muon | 4.5.33

Reproducible on current live release:
no

Additional Information

Related to #9029

cc @diracdeltas
@LaurenWags LaurenWags added 0.20.x issue first seen in 0.20.x bug feature/shields labels Jan 4, 2018
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 4, 2018
@diracdeltas diracdeltas self-assigned this Jan 4, 2018
diracdeltas added a commit that referenced this issue Jan 5, 2018
@diracdeltas
migrate fp site settings when fp has not been toggled globally
178419d 
fix #12497 by doing the site settings migration even when fingerprinting protection's global setting has not been changed.

Test Plan:
1. in a fresh 0.19.x profile, go to any website and enable fingerprinting protection on it
2. now update to 0.20.x or later
3. re-open brave and go to the website from step 1
4. open page shields. it should say 'block all fingerprinting'.
@diracdeltas diracdeltas mentioned this issue Jan 5, 2018
Merged
10 tasks
diracdeltas added a commit that referenced this issue Jan 11, 2018
@diracdeltas
migrate fp site settings when fp has not been toggled globally
61d2929 
fix #12497 by doing the site settings migration even when fingerprinting protection's global setting has not been changed.

Test Plan:
1. in a fresh 0.19.x profile, go to any website and enable fingerprinting protection on it
2. now update to 0.20.x or later
3. re-open brave and go to the website from step 1
4. open page shields. it should say 'block all fingerprinting'.
This was referenced Jan 22, 2018
Closed
Closed
Closed
This was referenced Jan 24, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
0.20.x issue first seen in 0.20.x bug feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
5 participants
@diracdeltas @kjozwiak @luixxiul @srirambv @LaurenWags