Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reconcile shouldn't happen when ledger table is empty #13325

Closed
srirambv opened this issue Feb 27, 2018 · 3 comments
Closed

Reconcile shouldn't happen when ledger table is empty #13325

srirambv opened this issue Feb 27, 2018 · 3 comments
Assignees
@ryanml
Labels
bug feature/rewards initiative/bat-payments priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 3 ...

Comments

@srirambv
Copy link
Collaborator

Description

Reconcile shouldn't happen when ledger table is empty

Steps to Reproduce

  1. Clean install 0.21.16, do not visit any site
  2. Enable payment and add funds to wallet
  3. Change reconcile stamp to older date, wait for the reconcile to process
  4. Amount from wallet is deducted based on the monthly budget even with out any entry for ledger table

Actual result:
Reconcile happens even when ledger table is empty

Expected result:
Reconcile shouldn't happen when ledger table is empty

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.16
V8 6.4.388.41
rev a7bed47
Muon 4.8.2
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:
Yes

Additional Information
@srirambv srirambv added this to the 0.22.x (Developer Channel) milestone Feb 27, 2018
@alexwykoff alexwykoff modified the milestones: 0.22.x (Developer Channel), Backlog (Prioritized) Feb 27, 2018
@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Feb 27, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Mar 5, 2018
@ryanml
Fixes Issue brave#13325, a reconcile is no longer triggered during ru…
f4685c1 
…n if there are no publishers in the ledger table.
ryanml added a commit to ryanml/browser-laptop that referenced this issue Mar 5, 2018
@ryanml
Fixes Issue brave#13325, a reconcile is no longer triggered during ru…
07d8045 
…n if there are no publishers in the ledger table.
@ryanml ryanml mentioned this issue Mar 5, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), Completed work Apr 6, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Apr 6, 2018
@ryanml
Fixes Issue brave#13325, a reconcile is no longer triggered during ru…
6d3f795 
…n if there are no publishers in the ledger table.
@NejcZdovc NejcZdovc modified the milestones: Completed work, 0.22.x Release 2, 0.22.x Release 3 (Beta channel) Apr 10, 2018
This was referenced May 3, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented May 3, 2018

image

After updating reconcile stamp and launching browser with LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true, shows Last contribution as Currently Processing. Should remain No previous contributions as there hasn't been any payment done.

@srirambv srirambv reopened this May 3, 2018
@srirambv srirambv closed this as completed May 3, 2018
@srirambv srirambv mentioned this issue May 3, 2018
Closed
@LaurenWags
Copy link
Member

Needs to be tested after #14018 is included.

This was referenced May 8, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented May 8, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified on macOS 10.13.3 x64 using the following build:

  • 0.22.703 903b8d0
  • libchromiumcontent: 66.0.3359.139
  • muon: 6.0.8

Verified on Ubuntu 17.10 x64

  • 0.22.706 e11b027
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.9

@kjozwiak kjozwiak mentioned this issue May 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
bug feature/rewards initiative/bat-payments priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
7 participants
@alexwykoff @kjozwiak @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski