Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension popups empty and transparent on first click after Brave restart #13633

Closed
echosa opened this issue Mar 28, 2018 · 20 comments
Closed

Extension popups empty and transparent on first click after Brave restart #13633

echosa opened this issue Mar 28, 2018 · 20 comments

Comments

@echosa
Copy link
Contributor

echosa commented Mar 28, 2018

Description

When I open or restart Brave, then click on the Bitwarden icon, the resulting extension popup is transparent. This seems to only happen on the first click of each browser restart. A second click fixes the issue.

Steps to Reproduce

  1. Enable Bitwarden. (You might need to actually set up the account/login. Not sure.0
  2. Restart Brave.
  3. Click on the Bitwarden icon.

Actual result:
screen shot 2018-03-28 at 9 16 12 am

Expected result:
screen shot 2018-03-28 at 9 19 53 am

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.21.24 
V8: 6.5.254.36 
rev: 19c78a1624118e344852c4c0f44c0d45be841b5f 
Muon: 4.9.3 
OS Release: 17.4.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.162

Reproducible on current live release:
Yes

Additional Information

I'm not sure if this affects other extensions, like LastPass.

@bsclifton
Copy link
Member

cc: @jonathansampson

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 2, 2018

Not limited to password managers; this repros with MetaMask and other extensions too. I am able to reproduce this, as was @petemill.

My instance:

Brave: 0.22.13 
V8: 6.5.254.41 
rev: a8cfb160479f1d00d0769368eb440030182bb83b 
Muon: 5.1.2 
OS Release: 10.0.16299 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

@echosa echosa changed the title Bitwarden extension popup empty and transparent on first click after Brave restart Extension popups empty and transparent on first click after Brave restart Apr 2, 2018
@Jacalz
Copy link
Contributor

Jacalz commented Apr 15, 2018

Yeah I have noticed this issue as well on Bitwarden and I double checked Metamask and the same issue is there just like Jonathan said 😅

@LaurenWags
Copy link
Member

@kjozwiak
Copy link
Member

kjozwiak commented May 3, 2018

Still an issue with 0.22.669 6cda2e8. Reproduced on Mint 18.3 x64 and macOS 10.13.3 x64.

@Jacalz
Copy link
Contributor

Jacalz commented May 3, 2018

Yeah still an issue with 0.22.669 on Windows 10

@StephenBass
Copy link

StephenBass commented May 4, 2018

+1 from the BAT Telegram https://t.me/batproject/50473
User on Windows 10 - Brave 0.22.669

@LaurenWags
Copy link
Member

@eljuno
Copy link
Contributor

eljuno commented Jun 5, 2018

@cndouglas
Copy link

This may be fixed-with-brave-core.

@GeetaSarvadnya
Copy link
Collaborator

@davidtemkin
Copy link

Let's discuss this on Tuesday. Seems like we should prioritize. @bsclifton @kjozwiak @bbondy @diracdeltas

@rsfxiii
Copy link

rsfxiii commented Jul 18, 2018

Couldn't find instructions on how to report a build properly, so feel free to steer me to that for more info, but I was dealing with having MetaMask & other extensions be totally unusable and the only one (MetaMask) I cared about being broken.

Disabling the following settings in my Mac running High Sierra 10.13.5 allowed at least MetaMask to render and be usable again, so I haven't done testing outside this:

  • Disable Google Wildvine
  • Disable Adobe Flash Support
  • Disable PDF Viewer extension

I have an inkling the former two didn't matter as much as the third, but that's a hunch. Hopefully this helps in some fashion. I would test around this in particular. Let me know if I can provide more detail and what.

@bridiver
Copy link
Collaborator

this is not a regression, is there a reason this is blocking c68? Chromium updates should normally only be blocked for regressions.

@bridiver
Copy link
Collaborator

fyi - this issue is as old as extension popups on Brave

@davidtemkin
Copy link

We need this for our MetaMask-integrated local ETH wallet, which is shipping in the C68 release. Can't launch with first click on MetaMask showing a blank frame when it is part of the marketing announcement.

@petemill
Copy link
Member

WebView is correctly in the DOM with a valid src attribute. Hiding and showing via CSS is working correctly, so this may be solvable with a workaround from browser-laptop instead of muon.

petemill added a commit that referenced this issue Jul 20, 2018
… opened

Fix #13633 via a workaround to hide and show the webview after the first time it is attached to a new WebContents.
Also avoid flash of different sizes by only setting a new size once the page has finished load (success or fail).
@petemill petemill self-assigned this Jul 20, 2018
petemill added a commit that referenced this issue Jul 20, 2018
… opened

Fix #13633 via a workaround to hide and show the webview after the first time it is attached to a new WebContents.
Also avoid flash of different sizes by only setting a new size once the page has finished load (success or fail).
petemill added a commit that referenced this issue Jul 20, 2018
… opened

Fix #13633 via a workaround to hide and show the webview after the first time it is attached to a new WebContents.
Also avoid flash of different sizes by only setting a new size once the page has finished load (success or fail).
petemill added a commit that referenced this issue Jul 20, 2018
… opened

Fix #13633 via a workaround to hide and show the webview after the first time it is attached to a new WebContents.
Also avoid flash of different sizes by only setting a new size once the page has finished load (success or fail).
@LaurenWags
Copy link
Member

@petemill is additional testing needed other than the steps to reproduce?

@btlechowski
Copy link
Contributor

btlechowski commented Jul 25, 2018

Verified on Ubuntu 17.10 x64

  • 0.23.72 c3b1cac
  • Muon 8.0.2
  • libchromiumcontent 68.0.3440.75

Verified on Windows 10 x64

  • 0.23.72 c3b1cac
  • Muon 8.0.2
  • libchromiumcontent 68.0.3440.75

Verified with macOS 10.12.6 using

  • 0.23.73 50bdb6d
  • Muon 8.0.3
  • libchromiumcontent 68.0.3440.75

@petemill
Copy link
Member

@LaurenWags I think it’s wise to enable all extensions that have pop ups and check they each open and display correctly, on each desktop platform.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.