map keyboard shortcut to new tor private tab

[diracdeltas]

Test plan

See #14711

Original issue description

cmd/ctrl + shift + N perhaps

[bradleyrichter]

I think we should steer clear of Chrome's current shortcut for new private window but [command + Option + N] appears to be vacant on Mac OS Brave and Mac OS Chrome.

Needs a check on Windows

cc @diracdeltas @petemill

[diracdeltas]

@bradleyrichter what about cmd + option + [whatever the last key for private tab is]? so on current browserlaptop it would be cmd+option+p and on brave-core it would be cmd+option+n

[BrendanEich]

I like @diracdeltas’ idea although it is big key chord.

Separately I’ve been advocating for N not P to match other browsers.

[bradleyrichter]

We all agree. Same suggestions for Brave-Core. Command+Option+N

Command+Option+P is fine for Muon. TY...

[alexwykoff]

Official :
New Private Tab becomes Command + Shift + N (on Mac)
New Private Tab with Tor becomes Command + Option + N (on Mac)

[diracdeltas]

i'm doing other release/blocking issues and this one is pretty straightforward, so someone can take it if they feel like it

[LaurenWags]

Verified with macOS 10.12.6 using

• 0.23.33 f3426e8
• Muon 7.1.5
• libchromiumcontent 67.0.3396.103

Verified on Ubuntu 17.10 x64

• 0.23.37 47b1b59
• Muon 7.1.6
• libchromiumcontent 67.0.3396.103
  The shortcut CTRL+ALT+N open new tor tab

[srirambv]

Failed on windows. Logged issue #14716