Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Feature request: Persistence Tor-mode option on private tabs #14637

Closed
mrphs opened this issue Jul 3, 2018 · 10 comments
Closed

Feature request: Persistence Tor-mode option on private tabs #14637

mrphs opened this issue Jul 3, 2018 · 10 comments

Comments

@mrphs
Copy link

mrphs commented Jul 3, 2018

Description

I've been using Brave + Tor for only a couple of days and I already find it tiring to enable Tor-mode for every time I open a new private tab. More importantly, I sometimes forget about turning it on, only to find out when it's already too late.

Having a check box under the Tor mode toggle button that remembers my choice would be super duper!

Brave Version

Name Version
Brave 0.23.19
V8 6.7.288.46
rev 178c3fb
Muon 7.1.3
OS Release 17.6.0
Update Channel Release
OS Architecture x64
OS Platform macOS
Node.js 7.9.0
Tor 0.3.3.7 (git-035a35178c92da94)
Brave Sync v1.4.2
libchromiumcontent 67.0.3396.87
@srirambv
Copy link
Collaborator

srirambv commented Jul 3, 2018

There's a context menu option to open Tor tabs directly on the new tab button. You can right click and open Tor tab. The same option is available via file menu and on kabob menu as well. Does that help?

@riastradh-brave
Copy link
Contributor

Our initial draft did have a persistent Tor setting for all private tabs. We changed it a few weeks ago so that users would have greater control over whether they would have Tor or not in each tab. In the short term, we plan to add a keyboard shortcut: #14504 In the longer term, the UX desgin for all this is still in flux!

@NumDeP
Copy link

NumDeP commented Jul 6, 2018

Hi @riastradh-brave don't you think moving the 'Support jump lists' #6094 issue forward to include the new Tor feature would be more ideal?

In addition, this way when a user makes his/her first attempt connecting to Tor they could do so without any leak (hopefully), where as manually opening the browser from icon in start/desktop menu, they would connect to local internet, not to mention waste time however little it may be, then click on the New PTT, waiting for it to connect to Tor, slightly inefficient, isn't it.
It would be brilliant if Brave were to open Tor literally from startup without any leaks like the traditional Firefox-Tor and I don't see any other better way a user could do so without the above support for Jump Lists.

EDIT: Or is this one of the long term UX design in flux?

@riastradh-brave
Copy link
Contributor

Also FYI: #14649

@riastradh-brave
Copy link
Contributor

@NumDeP As of 0.23.31, Brave makes no attempt to connect to the Tor network until you open a private tab with Tor. #14617

@hugobuddel
Copy link
Contributor

It would also be nice to have Ctrl-T open a Tor-tab when already on a Tor-tab. (And perhaps the same for private tabs.) Or a keyboard shortcut to open Tor-tabs directly.

@NumDeP
Copy link

NumDeP commented Jul 10, 2018

@hugobuddel they're discussing it here #14504 though it's probably finalized. I would have preferred 'B', firstly because it's not a long stretch and secondly it would come across as TPB in the menu.

@NumDeP
Copy link

NumDeP commented Jul 10, 2018

@riastradh-brave I'm aware of 'Lazy load Tor instead...' :) which is why I thought it may be better for those some individuals that it benefits and prefer it loading on startup to still have the ability to do so from the jump-list. Opinions seem to differ slightly among users including in the community, sorry for troubling you guys and I don't know whose complaining about startup, I'm using it Linux and honestly speaking, you lot have done a brilliant job so far.

@riastradh-brave
Copy link
Contributor

In the next release, we will have a keyboard shortcut for opening a tab with Tor: #14504. We're also changing the shortcut for opening a private tab to be closer to Chromium: #14711. Specifically:

  • macOS: cmd-shift-n for private tab, cmd-opt-n for private tab with Tor
  • Others: ctrl-shfit-n for private tab, ctrl-alt-n for private tab with Tor

For the longer-term, we are still exploring the design space of how Tor fits into Brave: #14649

@mrphs Does this help?

@bsclifton
Copy link
Member

Closing in favor of brave/brave-browser#690

@bsclifton bsclifton added wontfix post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). open-in-brave-core and removed post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). labels Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants