-
Notifications
You must be signed in to change notification settings - Fork 974
Unable to scroll down bookmarks tab when populated beyond initial display boundry #14606
Comments
+1 from @defcon1776 via brave/brave-browser#455 |
+1 from me |
This was broken with 681349d where |
@NejcZdovc thanks for the find. This should probably be simply positioned at |
Fix #14606 Fixes context menu overflow scroll, returning it to previous behavior. Note that previous behavior is flawed as it only calculates an approximation of available space. It does not cover dynamic 'navbar' height such as menu bar or notifications presence. It could be much more gracefully achieved via `bottom: 0` positioning and would look better by creating a container element which has `max-height: 100%` on it so that the inside of the menu box scrolled rather than the border scrolling away wierdly.
+1 from Twitter https://twitter.com/voxtis/status/1014591450380562432 |
+1 from Twitter https://twitter.com/napersmikekim/status/1016131747044642817 |
Verified with macOS 10.12.6 using
Verified on Windows x64 with
Verified on Ubuntu 17.10 x64
Verified on Windows x64 with |
+1 from a private PM on community.brave... mentioned that it's been fixed and will be released sometime Monday 👍 |
Description
After updating (0.23.19) users are unable to scroll down a list of bookmarks when the bookmarks tab is open (and populated with enough links to require scrolling)
Steps to Reproduce
Expected result:
Scroll bar should appear after 1 or more bookmarks added, allowing you to move down tab to see new additions
Reproduces how often:
Always
Brave Version
about:brave info:
Despite asking nobody provided their about:brave info, but I was able to reproduce the error so we'll use mine:
Brave: 0.23.19
V8: 6.7.288.46
rev: 178c3fb
Muon: 7.1.3
OS Release: 10.0.16299
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Tor: 0.3.3.7 (git-035a35178c92da94)
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.87
Reproducible on current live release:
Yes
Additional Information
Seems to be a regression as far as I can tell. I was unable to reproduce error one previous release and can produce error 100% on live release.
The text was updated successfully, but these errors were encountered: