search icon in URLbar should be a local resource

[diracdeltas]

we discovered while running wireshark on Tor tabs that the search icon in the urlbar (google, duckduckgo) is loaded remotely when the user starts a search from the urlbar. for privacy it's best to load it as a local resource.

STR:
open browser console and inspect the urlbar icon
hit any search shortcut, ex: ':g' for google
notice that the favicon for the search engine is loaded from a remote website

[srirambv]

This is breaking the search favicon

[diracdeltas]

i tested it on mac so may be a windows specific issue breakage

[alexwykoff]

We'll need to test this with a large profile per @kjozwiak

[LaurenWags]

Verified icons using engine go key (from about:preferences#search), all seemed to load fine except for searx (:x). Reproduced by @srirambv

[diracdeltas]

@LaurenWags is that on windows?

[diracdeltas]

@LaurenWags also what's the error in the console?

[LaurenWags]

@diracdeltas this is on macOS but was reproduced on Win. Doesn't appear to be anything in the console:

[diracdeltas]

@LaurenWags thanks - looked like there was a console error in your first screenshot (red x)

[LaurenWags]

so there is, interesting. the console error isn't reproducing now but will try a few more times and update here if I get something @diracdeltas

[diracdeltas]

i think i know what the issue is

[srirambv]

Verified on Windows x64 using

• 0.23.34 a471718
• Muon 7.1.6
• libchromiumcontent 67.0.3396.103

Verified with macOS 10.12.6 using

• 0.23.34 a471718
• Muon 7.1.6
• libchromiumcontent 67.0.3396.103

Verified on Ubuntu 17.10 x64

• 0.23.34 a471718
• Muon 7.1.6
• libchromiumcontent 67.0.3396.103

Verified on Windows x64 with
• 0.23.37 47b1b59
• Muon 7.1.6
• libchromiumcontent 67.0.3396.103