Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

nytimes short links crash in tor tabs #14806

Closed
btlechowski opened this issue Jul 23, 2018 · 2 comments
Closed

nytimes short links crash in tor tabs #14806

btlechowski opened this issue Jul 23, 2018 · 2 comments
Assignees
@darkdh
Labels
bug cr68 crash feature/tor priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.23.x Release 4 ...

Comments

@btlechowski
Copy link
Contributor

Steps to Reproduce

  1. Open tor tab
  2. Open https://t.co/5LI7kjOzRn
  3. Wait 30 seconds

Actual result:
Crash
[1:1:0100/000000.958496:ERROR:broker_posix.cc(43)] Invalid node channel message

Expected result:
No crash

Reproduces how often:
always

Brave Version

Brave: 0.23.70 
V8: 6.8.275.23 
rev: e63c7804ea4850229904d4dc991143e1ebeabb51 
Muon: 8.0.1 
OS Release: 4.13.0-21-generic 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Tor: 0.3.3.8 (git-99f9816efa08ab83) 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.68

Reproduced on MacOS by @LaurenWags
Reproduced on Windows 10 by @srirambv

Reproducible on current live release:

cc @riastradh-brave @darkdh @kjozwiak @bsclifton @GeetaSarvadnya
@btlechowski btlechowski mentioned this issue Jul 23, 2018
Closed
@NumDeP NumDeP mentioned this issue Jul 24, 2018
Closed
@alexwykoff alexwykoff added priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. release/blocking labels Jul 24, 2018
darkdh added a commit to brave/muon that referenced this issue Jul 25, 2018
@darkdh
set_site_for_service_worker for isolated storage so that
0cf4424 
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have
correct site instance set by `use_url_from_storage_partition`

fix brave/browser-laptop#14806

Auditor: @bridiver
@darkdh
Copy link
Member

darkdh commented Jul 25, 2018

fixed in brave/muon@0cf4424
muon build 8.0.2

@darkdh darkdh closed this as completed Jul 25, 2018
darkdh added a commit to brave/muon that referenced this issue Jul 25, 2018
@darkdh
set_site_for_service_worker for isolated storage so that
2e51a44 
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have
correct site instance set by `use_url_from_storage_partition`

fix brave/browser-laptop#14806

Auditor: @bridiver
darkdh added a commit to brave/muon that referenced this issue Jul 25, 2018
@darkdh
set_site_for_service_worker for isolated storage so that
4254328 
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have
correct site instance set by `use_url_from_storage_partition`

fix brave/browser-laptop#14806

Auditor: @bridiver
darkdh added a commit to brave/muon that referenced this issue Jul 25, 2018
@darkdh
set_site_for_service_worker for isolated storage so that
8af7c76 
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have
correct site instance set by `use_url_from_storage_partition`

fix brave/browser-laptop#14806

Auditor: @bridiver
darkdh added a commit to brave/muon that referenced this issue Jul 25, 2018
@darkdh
set_site_for_service_worker for isolated storage so that
abd9ca9 
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have
correct site instance set by `use_url_from_storage_partition`

fix brave/browser-laptop#14806

Auditor: @bridiver
This was referenced Jul 25, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jul 25, 2018 •
edited by btlechowski
Loading

Verified on Windows 10 x64 using

  • 0.23.72 c3b1cac
  • Muon 8.0.2
  • libchromiumcontent 68.0.3440.75

Verified with macOS 10.12.6 using

  • 0.23.72 c3b1cac
  • Muon 8.0.2
  • libchromiumcontent 68.0.3440.75

Verified on Ubuntu 17.10 x64

  • 0.23.72 c3b1cac
  • Muon 8.0.2
  • libchromiumcontent 68.0.3440.75

darkdh added a commit to brave/muon that referenced this issue Aug 3, 2018
@darkdh
set_site_for_service_worker for isolated storage so that
62f9261 
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have
correct site instance set by `use_url_from_storage_partition`

fix brave/browser-laptop#14806

Auditor: @bridiver
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug cr68 crash feature/tor priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.23.x Release 4 w/ Chromium 68 (Rele...
Development

No branches or pull requests
6 participants
@alexwykoff @kjozwiak @darkdh @srirambv @LaurenWags @btlechowski