-
Notifications
You must be signed in to change notification settings - Fork 974
Fix Cross-Origin Read Blocking (CORB) for extensions #14841
Comments
Per @darkdh
@jonathansampson has updated the LastPass extension to |
No, the API issue has been there for a long time and it is a easy fix.
|
checking on extensions from CrossSiteDocumentResourceHandler::ShouldBlockBasedOnHeaders fix brave/browser-laptop#14841 Auditors: @bridiver, @bbondy
CORB error fixed by brave/muon@3c654ff will be available in muon 8.0.3 |
checking on extensions from CrossSiteDocumentResourceHandler::ShouldBlockBasedOnHeaders fix brave/browser-laptop#14841 Auditors: @bridiver, @bbondy
Re-opening as issue may have been re-introduced. @darkdh can address this soon with a new Muon |
checking on extensions from CrossSiteDocumentResourceHandler::ShouldBlockBasedOnHeaders fix brave/browser-laptop#14841 Auditors: @bridiver, @bbondy
fixed in muon 8.0.9 |
Verified on Windows 10 x64 using
Passed with macOS 10.12.6 using
PASSed on Ubuntu 17.10 x64
|
FIXED: tested on Win 10 x64 Brave: 0.23.105 Verified no errors when opening the extension popup |
@stellar6 thanks for double checking! Really appreciate it! 👍 |
@kjozwiak this was posted an hour ago mentioning an issue still persists with generating and fill and add new pass on MacOS - https://community.brave.com/t/lastpass-still-not-working/31111 |
Description
Lastpass login page not shown on clean profile
Test plan / Steps to Reproduce
Actual result:
Expected result:
Extension should load
Reproduces how often:
100% on new profile
Reproduced on mac by @LaurenWags
Brave Version
about:brave info:
Brave|
--|--0.23.72
V8|6.8.275.24
rev|c3b1cac
Muon|8.0.2
OS Release|10.0.17134
Update Channel|Release
OS Architecture|x64
OS Platform|Microsoft Windows
Node.js|7.9.0
Brave Sync|v1.4.2
libchromiumcontent|68.0.3440.75
Reproducible on current live release:
No
Additional Information
When lastpass is enabled on Beta and then enabled on release channel it shows correct login popup page. Issue happens only when trying on release channel
The text was updated successfully, but these errors were encountered: