Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave Crashes when visiting a certain URL #14893

Closed
LaurenWags opened this issue Aug 1, 2018 · 17 comments
Closed

Brave Crashes when visiting a certain URL #14893

LaurenWags opened this issue Aug 1, 2018 · 17 comments
Assignees
@jumde @bsclifton @darkdh
Labels
crash QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Hotfix (Re...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 1, 2018 •
edited
Loading

Test Plan

See STR and #14893 (comment)

Description

Reported via community: https://community.brave.com/t/brave-process-terminates-when-loading-url/28790

When visiting http://www.conservativehq.com/node/28451 Brave crashes on Mac and Win.

Steps to Reproduce

  1. Launch 0.23.73
  2. Visit http://www.conservativehq.com/node/28451

Actual result:
Brave crashes. Crash report ID on mac: 67f25bbc21a5ee2c

Expected result:
Brave should not crash

Reproduces how often:
easily

Brave Version

about:brave info:

Brave: 0.23.73
V8: 6.8.275.24
rev: 50bdb6d
Muon: 8.0.3
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 68.0.3440.75

Reproducible on current live release:
Yes

Additional Information

Reproduced on macOS and Win by @kjozwiak

This link did not crash on 0.23.39
@LaurenWags
Copy link
Member Author

+1 for crashes from twitter: https://twitter.com/PedanticBword/status/1024658809162223616
Crash Report IDs:
1a7b529676a34ddf (Local Crash ID: 0ac6cc6a-0af3-4dd3-91e5-2c480f4f061e)
1aa5bec207492e3e (Local Crash ID: 66b04a55-b831-4149-ac36-36ff54e1f8c8)
024af5cda9019cd9 (Local Crash ID: 5c84bda1-8db8-48cd-9b38-a1bc2785ed60)
4b73e356225a25cc (Local Crash ID: 7800e4c4-0b3f-4aa3-9e1c-63a349124e63)
1cf7681dfb285c81 (Local Crash ID: f2eee1e4-8909-4780-be95-0cbe09d47dcd)
f0439c12e8d74be3 (Local Crash ID: 012c1774-c346-4911-aed5-dc54881d3e18)
696939abbb62b8fa (Local Crash ID: ddbac8d7-0ff6-41d9-a100-e5617873dd43)
bd36cac418957129 (Local Crash ID: aa2c79cc-d858-4589-a278-40a851c6f4f9)
088bf5cbf5788ddc (Local Crash ID: 2e606c40-7f75-498e-80a6-a0b739db6f2c)
63dffa747025e084 (Local Crash ID: 6b9946b7-4982-4f7b-91b9-883e692a87fd)
6be6ddbe3e226e28 (Local Crash ID: 9f06e944-8e03-4634-b163-a9859c8a8ba0)
8aeeb6a38094fa1d (Local Crash ID: ab58da87-8a6a-45c7-ae8c-70e075891990)

@kjozwiak
Copy link
Member

kjozwiak commented Aug 1, 2018

Here's the crash ID's for the Win 10 x64 crashes when going through the above STR:

  • d18540190fa534c8
  • ae0e2521f6fae877

@LaurenWags
Copy link
Member Author

Also, if you had a site (like the one above which is http://www.conservativehq.com/node/28451) open in 0.23.39, and then you update to 0.23.73, Brave crashes on launch of 0.23.73.

@MikeCondra
Copy link

Lauren,

Here are crash IDs from Windows 10, Brave 0.23.73:

10f68f07dc1fd8aa (Local Crash ID: 7af34812-58e0-4972-92d7-34140fe66e9c)
2988e44c8a2f18f5 (Local Crash ID: c255207f-74d8-4671-b9a2-851342c3a0ef)
3aea5a78f189ff19 (Local Crash ID: 9d14897e-a2b3-4ccc-9225-9d41524c04d0)
8791941af32f7c03 (Local Crash ID: 3be1ac4c-9c71-47ad-a034-3e1e69904363)

@bsclifton
Copy link
Member

@jumde is checking this out... here's the symbolized stack trace:

Thread 1 "brave" received signal SIGTRAP, Trace/breakpoint trap.
0x00000000033cdc66 in content::WebContentsImpl::~WebContentsImpl (this=0x1735c38c6000) at ../../content/browser/web_contents/web_contents_impl.cc:559
559      CHECK(!is_being_destroyed_);
(gdb) bt
#0  0x00000000033cdc66 in content::WebContentsImpl::~WebContentsImpl() (this=0x1735c38c6000) at ../../content/browser/web_contents/web_contents_impl.cc:559
#1  0x00000000033ce0ee in content::WebContentsImpl::~WebContentsImpl() (this=0x1735c38c6000) at ../../content/browser/web_contents/web_contents_impl.cc:556
#2  0x00000000033de080 in content::WebContentsImpl::ShowCreatedWindow(int, int, WindowOpenDisposition, gfx::Rect const&, bool) (__ptr=0x1735c38c6000, this=<optimized out>)
    at ../../buildtools/third_party/libc++/trunk/include/memory:2321
#3  0x00000000033de080 in content::WebContentsImpl::ShowCreatedWindow(int, int, WindowOpenDisposition, gfx::Rect const&, bool) (this=0x0, __p=<optimized out>)
    at ../../buildtools/third_party/libc++/trunk/include/memory:2634
#4  0x00000000033de080 in content::WebContentsImpl::ShowCreatedWindow(int, int, WindowOpenDisposition, gfx::Rect const&, bool) (this=0x0)
    at ../../buildtools/third_party/libc++/trunk/include/memory:2588
#5  0x00000000033de080 in content::WebContentsImpl::ShowCreatedWindow(int, int, WindowOpenDisposition, gfx::Rect const&, bool) (this=<optimized out>, process_id=<optimized out>, main_frame_widget_route_id=<optimized out>, disposition=WindowOpenDisposition::NEW_POPUP, initial_rect=..., user_gesture=<optimized out>)
    at ../../content/browser/web_contents/web_contents_impl.cc:2634
#6  0x0000000003155ccb in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) (this=<optimized out>, pending_widget_routing_id=6, disposition=WindowOpenDisposition::NEW_POPUP, initial_rect=..., user_gesture=<optimized out>) at ../../content/browser/frame_host/render_frame_host_impl.cc:3027

@bsclifton
Copy link
Member

Looking at recent commits (we're in process of updating to latest stable Chromium 68)... I noticed this patch which fixes a crash:
https://chromium.googlesource.com/chromium/src/+/3cccf1a40279cf1f5d789358f80c15deb6c884c2

@jumde has repro'd the issue and will be trying with latest Chromium here

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 2, 2018 •
edited
Loading

@bsclifton here are some additional crash reports from users but the users weren't necessarily attempting to visit the URL in the description:
from https://community.brave.com/t/crash-when-using-yahoo-mail-print-menu/28840
Uploaded Crash Report ID 3dc6af7970529aa9
Uploaded Crash Report ID e448bf2eecbafeda

from https://community.brave.com/t/brave-0-23-73-crashes-when-clicking-a-link-but-clicking-same-link-in-source-page-works/28885
Uploaded Crash Report ID fa06ea5654689795
Uploaded Crash Report ID d936fc86c48840bc

from https://community.brave.com/t/brave-crashes-when-opening-a-particular-site/28838/12
Uploaded Crash Report ID e434c2784afc0fcf
Uploaded Crash Report ID c597feef969f831a
Uploaded Crash Report ID e81b124f5efcf6dd

from https://community.brave.com/t/brave-crashes-when-opening-a-particular-site/28838/15 - user is having trouble uploading crash reports. This post has zip file with local crash .dmp files.

@jumde
Copy link
Contributor

jumde commented Aug 2, 2018

Reduced PoC:

<script>
  window.open('http://www.brave.com');
</script>

 
Brave: 0.23.74 
V8: 6.8.275.24 
rev: b508fa785acc195be2701ddd987139f0b581e7db 
Muon: 8.0.4 
OS Release: 17.7.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.84

@bsclifton
Copy link
Member

bsclifton commented Aug 2, 2018 •
edited
Loading

Here's a very simple static page which uses @jumde 's PoC:
https://media.clifton.io/issue-14893.html

edit: crash confirmed on macOS and Windows - @jumde has confirmed on Linux I believe

@LaurenWags LaurenWags mentioned this issue Aug 2, 2018
Closed
bridiver added a commit to brave/muon that referenced this issue Aug 2, 2018
@bridiver
release new_contents in all cases so we can continue to manage its li…
25c2ab2 
…fetime without any other changes for now

fixes brave/browser-laptop#14893
auditors @darkdh
darkdh pushed a commit to brave/muon that referenced this issue Aug 3, 2018
@bridiver @darkdh
release new_contents in all cases so we can continue to manage its li…
f58697f 
…fetime without any other changes for now

fixes brave/browser-laptop#14893
auditors @darkdh
@bsclifton
Copy link
Member

Fixed with brave/muon@f58697f

This was referenced Aug 3, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Aug 3, 2018 •
edited by kjozwiak
Loading

Verified with the steps mentioned, browser doesn't crash
Verified on Windows 10 using

  • 0.23.77 0125b5f
  • Muon 8.0.6
  • libchromiumcontent 68.0.3440.84

Verified on Ubuntu 17.10 x64

  • 0.23.77 0125b5f
  • Muon 8.0.6
  • libchromiumcontent 68.0.3440.84

Verified on macOS 10.13.6 using the following build:

  • 0.23.77 0125b5f
  • muon 8.0.6
  • libchromiumcontent 68.0.3440.84

Ensured that opening the following two links didn't crash 0.23.77:

Open the above sites in: normal tabs, PB tabs, Tor PB tabs, session tabs and several new windows.

@rojour
Copy link

rojour commented Aug 3, 2018

Got version 23.74, tested with the latest update of MacOSX beta and still crash on download.
This time even crashed before it started to download.

@LaurenWags
Copy link
Member Author

Hi @rojour we've actually got version 0.23.77 out with crash fixes. You can download it from https://github.com/brave/browser-laptop/releases/tag/v0.23.77dev

@rojour
Copy link

rojour commented Aug 3, 2018 via email

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 3, 2018 •
edited
Loading

@rojour while using Mojave, is 0.23.77 crashing when you download (#14346) or crashing on launch?

@rojour
Copy link

rojour commented Aug 3, 2018 via email

@LaurenWags
Copy link
Member Author

gotcha, thanks for confirming @rojour - going to link your comment above to the Mojave specific download issue.

@kjozwiak kjozwiak mentioned this issue Aug 3, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Aug 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jumde jumde

@bsclifton bsclifton

@darkdh darkdh

Labels
crash QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Hotfix (Release Channel)
Development

No branches or pull requests
9 participants
@jumde @kjozwiak @bsclifton @rojour @MikeCondra @darkdh @srirambv @LaurenWags @btlechowski